Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use native font stack, drop external Lato font #1784

Merged
merged 7 commits into from
May 8, 2022
Merged

Use native font stack, drop external Lato font #1784

merged 7 commits into from
May 8, 2022

Conversation

mvorisek
Copy link
Member

@mvorisek mvorisek commented Apr 30, 2022 •
edited
Loading

finish external assets bundling (#1785)

fixes #1257, #1025

FUI issue for native support: fomantic/Fomantic-UI#2355, related PR: fomantic/Fomantic-UI#2359

and test Behat without internet connection (proxy all non localhost traffic to nonsense IP)

Visual comparison:

  1. original Lato font:
    image
  2. native font stack, default bold font weight (700)
    image
  3. native font stack, font weight 700 changed to 600
    image

@mvorisek mvorisek changed the title Replace external font, use native system font stack Use native system font stack, drop external Lato font download Apr 30, 2022
@mvorisek mvorisek added the MAJOR label Apr 30, 2022
@mvorisek mvorisek mentioned this pull request Apr 30, 2022
Merged
@mvorisek mvorisek changed the title Use native system font stack, drop external Lato font download Use native font stack, drop external Lato font download Apr 30, 2022
@mvorisek mvorisek changed the title Use native font stack, drop external Lato font download Use native font stack, drop external Lato font Apr 30, 2022
@mvorisek mvorisek marked this pull request as draft April 30, 2022 23:12
@mvorisek mvorisek mentioned this pull request May 1, 2022
Merged
@mvorisek mvorisek force-pushed the native_font_stack branch from b3479d0 to 1f53a80 Compare May 1, 2022 15:46
@mvorisek mvorisek changed the title Use native font stack, drop external Lato font Bundle Lato v2 font May 1, 2022
@mvorisek mvorisek force-pushed the native_font_stack branch from 90d54d1 to 82771f6 Compare May 1, 2022 17:01
@mvorisek mvorisek force-pushed the native_font_stack branch from 82771f6 to 48f48df Compare May 1, 2022 17:17
@mvorisek mvorisek force-pushed the native_font_stack branch from 2e77b02 to e580861 Compare May 7, 2022 17:35
@mvorisek mvorisek changed the title Bundle Lato v2 font Use native font stack, drop external Lato font May 8, 2022
@mvorisek mvorisek mentioned this pull request May 8, 2022
Merged
@mvorisek mvorisek force-pushed the native_font_stack branch from 25577cf to b53544e Compare May 8, 2022 10:28
@mvorisek mvorisek marked this pull request as ready for review May 8, 2022 11:24
@mvorisek mvorisek merged commit 7ec9f44 into develop May 8, 2022
@mvorisek mvorisek deleted the native_font_stack branch May 8, 2022 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
MAJOR
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default SUI/FUI font Lato v1 has issues with non-english characters
1 participant
@mvorisek