Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for native MySQL driver (mysqli) #952

Merged
merged 9 commits into from
Jan 7, 2022
Merged

Add support for native MySQL driver (mysqli) #952

merged 9 commits into from
Jan 7, 2022

Conversation

mvorisek
Copy link
Member

@mvorisek mvorisek commented Jan 6, 2022

to allow support of simultaneous queries :)

@mvorisek mvorisek force-pushed the mysqlnd branch 7 times, most recently from c8992b6 to 721d028 Compare January 7, 2022 09:41
@mvorisek mvorisek marked this pull request as ready for review January 7, 2022 10:27
@@ -16,6 +18,6 @@ class Query extends BaseQuery

public function groupConcat($field, string $delimiter = ',')
{
return $this->expr('group_concat({} separator [])', [$field, $delimiter]);
return $this->expr('group_concat({} separator \'' . str_replace('\'', '\'\'', $delimiter) . '\')', [$field]);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

php/php-src#7903

was actually a hidden issue

@mvorisek mvorisek added the MAJOR label Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants