separator for group_concat for mysql cannot be parametrized

Author: mvorisek

src/Persistence/Sql/Mysql/Query.php

@@ -18,6 +18,6 @@ class Query extends BaseQuery
 
     public function groupConcat($field, string $delimiter = ',')
     {
-        return $this->expr('group_concat({} separator [])', [$field, $delimiter]);
+        return $this->expr('group_concat({} separator \'' . str_replace('\'', '\'\'', $delimiter) . '\')', [$field]);
     }
 }

tests/Persistence/Sql/QueryTest.php

@@ -1082,7 +1082,7 @@ public function testGroupConcatException(): void
     public function testGroupConcat(): void
     {
         $q = new Mysql\Query();
-        $this->assertSame('group_concat(`foo` separator :a)', $q->groupConcat('foo', '-')->render()[0]);
+        $this->assertSame('group_concat(`foo` separator \'-\')', $q->groupConcat('foo', '-')->render()[0]);
 
         $q = new Oracle\Query();
         $this->assertSame('listagg("foo", :a) within group (order by "foo")', $q->groupConcat('foo', '-')->render()[0]);

tests/Persistence/Sql/RandomTest.php

@@ -88,7 +88,7 @@ public function _groupConcatTest(string $expected, Query $q): void
     public function testGroupConcat(): void
     {
         $this->_groupConcatTest(
-            'select `age`, group_concat(`name` separator :a) from `people` group by `age`',
+            'select `age`, group_concat(`name` separator \',\') from `people` group by `age`',
             new Mysql\Query()
         );