-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(conductor)!: implement v2 execution API #2006
Open
ethanoroshiba
wants to merge
6
commits into
main
Choose a base branch
from
eoroshiba/conductor-execution-sessions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit ead3a9b Author: ethanoroshiba <ethan@astria.org> Date: Mon Feb 10 17:23:16 2025 -0600 make start height the first execution height instead of one before commit d8f2f3f Author: ethanoroshiba <ethan@astria.org> Date: Mon Feb 10 16:48:39 2025 -0600 break proto changes into v2 commit dd16dc3 Author: ethanoroshiba <ethan@astria.org> Date: Mon Feb 10 12:30:34 2025 -0600 Fix evm restart test values, some verbiage changes for clarity commit 260e24c Author: ethanoroshiba <ethan@astria.org> Date: Mon Feb 10 10:20:18 2025 -0600 fix geth genesis commit 3cee398 Author: ethanoroshiba <ethan@astria.org> Date: Mon Feb 10 10:19:20 2025 -0600 fix values commit 0bfd35f Author: ethanoroshiba <ethan@astria.org> Date: Mon Feb 10 09:14:45 2025 -0600 fix rollup name in evm restart test dev values commit 8ade517 Author: ethanoroshiba <ethan@astria.org> Date: Mon Feb 10 08:56:16 2025 -0600 give evm rollup restart test its own just command commit b2af17c Merge: 1e1668e 60eefa9 Author: Richard Janis Goldschmidt <github@aberrat.io> Date: Mon Feb 10 13:53:08 2025 +0100 Merge branch 'main' into superfluffy/forma-restart-logic commit 1e1668e Author: ethanoroshiba <ethan@astria.org> Date: Fri Feb 7 13:40:56 2025 -0600 remove configmap values commit 782ee12 Author: ethanoroshiba <ethan@astria.org> Date: Fri Feb 7 13:36:55 2025 -0600 fix evm restart test heights, add env vars back to non dev configmap commit f5051d5 Author: Richard Janis Goldschmidt <github@aberrat.io> Date: Tue Feb 4 20:05:27 2025 +0100 remove grpc mock changes after rebasing on main commit 98d04a8 Author: Richard Janis Goldschmidt <github@aberrat.io> Date: Tue Feb 4 18:16:02 2025 +0100 fix proto formatting commit 373aaa0 Author: Richard Janis Goldschmidt <github@aberrat.io> Date: Tue Feb 4 18:09:46 2025 +0100 rename halt_at_stop_height -> halt_at_rollup_stop_height commit 6b9b54a Author: ethanoroshiba <ethan@astria.org> Date: Tue Feb 4 10:30:37 2025 -0600 bump charts, format core changelog commit 50010e9 Author: Richard Janis Goldschmidt <github@aberrat.io> Date: Tue Feb 4 14:43:14 2025 +0100 sequencer_end_height -> sequencer_stop_height commit 0be83ab Author: Richard Janis Goldschmidt <github@aberrat.io> Date: Tue Feb 4 14:36:50 2025 +0100 updated conductor, core changelogs commit faa42af Author: Richard Janis Goldschmidt <github@aberrat.io> Date: Tue Feb 4 14:32:09 2025 +0100 remove tendermint ID from public API of execution genesis commit 31caab9 Author: Richard Janis Goldschmidt <github@aberrat.io> Date: Tue Feb 4 14:19:02 2025 +0100 rename last_height -> stop_height commit 7b5b5fc Author: Richard Janis Goldschmidt <github@aberrat.io> Date: Tue Feb 4 14:10:19 2025 +0100 bump charts commit 4eb7806 Author: Richard Janis Goldschmidt <github@aberrat.io> Date: Tue Feb 4 13:56:57 2025 +0100 remove confusing test helper commit c586b33 Author: Richard Janis Goldschmidt <github@aberrat.io> Date: Tue Feb 4 13:53:18 2025 +0100 remove conductor_ prefix from tests, remove explicit sleep commit 42ae864 Author: ethanoroshiba <ethan@astria.org> Date: Thu Jan 30 11:54:10 2025 -0600 bring back executor tests, make test utils commit 66315e7 Author: ethanoroshiba <ethan@astria.org> Date: Thu Jan 30 11:36:14 2025 -0600 base stop height on rollup instead of sequencer commit 4ea3300 Author: ethanoroshiba <ethan@astria.org> Date: Tue Jan 28 12:33:39 2025 -0600 fix typos commit c720931 Author: ethanoroshiba <ethan@astria.org> Date: Tue Jan 28 12:26:14 2025 -0600 update changelog, example config, test soft-first and firm-first scenarios separately commit add58bc Author: ethanoroshiba <ethan@astria.org> Date: Mon Jan 27 12:29:55 2025 -0600 revert range changes commit d12ed9a Author: ethanoroshiba <ethan@astria.org> Date: Mon Jan 27 12:21:22 2025 -0600 add necessary charts changes and smoke test, change stop height to be inclusive commit a45206c Author: Richard Janis Goldschmidt <github@aberrat.io> Date: Wed Jan 22 06:14:49 2025 +0100 feat(conductor): restart or stop at set height Co-authored-by: Ethan Oroshiba <ethan@astria.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cd
ci
issues that are related to ci and github workflows
conductor
pertaining to the astria-conductor crate
docker-build
used to trigger docker builds on PRs
documentation
Improvements or additions to documentation
enhancement
New feature or request
evm
pertains to EVM
override-freeze
proto
pertaining to the Astria Protobuf spec
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates Conductor to use v2 Execution API, including use of new "execution sessions".
Background
These changes are necessary to support migrating Forma to mainnet.
Migrating Forma to Astria's main net requires introducing stop and start logic into the Conductor. A migration using these changes could look like this:
astria.execution.v2.CreateExecutionSession
, which containsrollup_start_block_number = 1
, androllup_end_block_number = 1000
.astria.execution.v2.CreateExecutionSession
, with new information from which it will continue executing.For cases where
rollup_end_block_number
is unset (or equivalently set to 0), conductor will never restart as there is no stop condition.For conductors running in firm-only or in soft-and-firm modes, only the firm-executed block triggers a restart (in soft-and-firm mode, upon soft-executing at the rollup stop number no blocks will be executed past it).
For conductors running in soft-only mode the soft-executed block triggers the restart.
If the rollup chain is halted, it should respond with
tonic::Code::FailedPrecondition
toCreateExecutionSession
, which will cause the Conductor to shut down upon attempting a restart.The aforementioned rollup changes to be made in
astria-geth
necessitate changing our current charts config for the following. "Forks" now describes a set of instructions for when and how to stop and restart the EVM at different heights, such that changes (such as network migration) can be made.Changes
In
astria-core
ExecutionSession
ExecutionSessionParameters
ExecutedBlockMetadata
CommitmentState
(name unchanged, but fields are)In
astria-auctioneer
In
astria-conductor
rollup_start_block_number
inExecutionSessionParameters
, so that Conductor doesn't start from rollup height 1 again after restarting.ASTRIA_CONDUCTOR_SEQUENCER_CHAIN_ID
andASTRIA_CONDUCTOR_CELESTIA_CHAIN_ID
env vars from Conductor (chain ID checks will now be performed against the values retrieved from the genesis info)In
charts
astriaForks
to EVM rollup config, to reflect changes inastria-geth
: https://github.com/astriaorg/astria-geth/pull/59/files.Testing
Changelogs
Changelogs updated
Breaking Changelist
Related Issues
closes #1994
closes #2003