Skip to content

Commit

Permalink
break proto changes into v2
Browse files Browse the repository at this point in the history
  • Loading branch information
ethanoroshiba committed Feb 10, 2025
1 parent dd16dc3 commit d8f2f3f
Show file tree
Hide file tree
Showing 24 changed files with 2,966 additions and 270 deletions.
2 changes: 1 addition & 1 deletion crates/astria-conductor/src/conductor/inner.rs
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ fn should_restart_or_shutdown(

#[cfg(test)]
mod tests {
use astria_core::generated::astria::execution::v1::{
use astria_core::generated::astria::execution::v2::{
Block,
CommitmentState,
GenesisInfo,
Expand Down
6 changes: 3 additions & 3 deletions crates/astria-conductor/src/executor/client.rs
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
use std::time::Duration;

use astria_core::{
execution::v1::{
execution::v2::{
Block,
CommitmentState,
GenesisInfo,
},
generated::astria::{
execution::{
v1 as raw,
v1::execution_service_client::ExecutionServiceClient,
v2 as raw,
v2::execution_service_client::ExecutionServiceClient,
},
sequencerblock::v1::RollupData,
},
Expand Down
2 changes: 1 addition & 1 deletion crates/astria-conductor/src/executor/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ use std::{
};

use astria_core::{
execution::v1::{
execution::v2::{
Block,
CommitmentState,
},
Expand Down
2 changes: 1 addition & 1 deletion crates/astria-conductor/src/executor/state.rs
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
use std::num::NonZeroU64;

use astria_core::{
execution::v1::{
execution::v2::{
Block,
CommitmentState,
GenesisInfo,
Expand Down
4 changes: 2 additions & 2 deletions crates/astria-conductor/src/executor/tests.rs
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
use astria_core::{
self,
execution::v1::{
execution::v2::{
Block,
CommitmentState,
GenesisInfo,
},
generated::astria::execution::v1 as raw,
generated::astria::execution::v2 as raw,
Protobuf as _,
};
use bytes::Bytes;
Expand Down
10 changes: 5 additions & 5 deletions crates/astria-conductor/src/test_utils.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
use astria_core::{
generated::astria::execution::v1::{
generated::astria::execution::v2::{
CommitmentState,
GenesisInfo,
},
Expand All @@ -10,7 +10,7 @@ use astria_core::{
use crate::executor::State;

pub(crate) fn make_commitment_state() -> CommitmentState {
let firm = astria_core::generated::astria::execution::v1::Block {
let firm = astria_core::generated::astria::execution::v2::Block {
number: 1,
hash: vec![42u8; 32].into(),
parent_block_hash: vec![41u8; 32].into(),
Expand All @@ -19,7 +19,7 @@ pub(crate) fn make_commitment_state() -> CommitmentState {
nanos: 789,
}),
};
let soft = astria_core::generated::astria::execution::v1::Block {
let soft = astria_core::generated::astria::execution::v2::Block {
number: 2,
hash: vec![43u8; 32].into(),
parent_block_hash: vec![42u8; 32].into(),
Expand Down Expand Up @@ -54,8 +54,8 @@ pub(crate) fn make_rollup_state(
genesis_info: GenesisInfo,
commitment_state: CommitmentState,
) -> State {
let genesis_info = astria_core::execution::v1::GenesisInfo::try_from_raw(genesis_info).unwrap();
let genesis_info = astria_core::execution::v2::GenesisInfo::try_from_raw(genesis_info).unwrap();
let commitment_state =
astria_core::execution::v1::CommitmentState::try_from_raw(commitment_state).unwrap();
astria_core::execution::v2::CommitmentState::try_from_raw(commitment_state).unwrap();
State::try_from_genesis_info_and_commitment_state(genesis_info, commitment_state).unwrap()
}
2 changes: 1 addition & 1 deletion crates/astria-conductor/tests/blackbox/firm_only.rs
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ use astria_conductor::{
Conductor,
Config,
};
use astria_core::generated::astria::execution::v1::{
use astria_core::generated::astria::execution::v2::{
GetCommitmentStateRequest,
GetGenesisInfoRequest,
};
Expand Down
12 changes: 6 additions & 6 deletions crates/astria-conductor/tests/blackbox/helpers/macros.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#[macro_export]
macro_rules! block {
(number: $number:expr,hash: $hash:expr,parent: $parent:expr $(,)?) => {
::astria_core::generated::astria::execution::v1::Block {
::astria_core::generated::astria::execution::v2::Block {
number: $number,
hash: ::bytes::Bytes::from(Vec::from($hash)),
parent_block_hash: ::bytes::Bytes::from(Vec::from($parent)),
Expand Down Expand Up @@ -59,7 +59,7 @@ macro_rules! commitment_state {
soft: (number: $soft_number:expr,hash: $soft_hash:expr,parent: $soft_parent:expr $(,)?),
base_celestia_height: $base_celestia_height:expr $(,)?
) => {
::astria_core::generated::astria::execution::v1::CommitmentState {
::astria_core::generated::astria::execution::v2::CommitmentState {
firm: Some($crate::block!(
number: $firm_number,
hash: $firm_hash,
Expand Down Expand Up @@ -116,7 +116,7 @@ macro_rules! genesis_info {
rollup_stop_block_number: $rollup_stop_block_number:expr,
halt_at_rollup_stop_number: $halt_at_rollup_stop_number:expr $(,)?
) => {
::astria_core::generated::astria::execution::v1::GenesisInfo {
::astria_core::generated::astria::execution::v2::GenesisInfo {
rollup_id: Some($crate::ROLLUP_ID.to_raw()),
sequencer_start_height: $start_height,
celestia_block_variance: $variance,
Expand Down Expand Up @@ -489,12 +489,12 @@ macro_rules! mount_get_block {
hash: $hash,
parent: $parent,
);
let identifier = ::astria_core::generated::astria::execution::v1::BlockIdentifier {
let identifier = ::astria_core::generated::astria::execution::v2::BlockIdentifier {
identifier: Some(
::astria_core::generated::astria::execution::v1::block_identifier::Identifier::BlockNumber(block.number)
::astria_core::generated::astria::execution::v2::block_identifier::Identifier::BlockNumber(block.number)
)};
$test_env.mount_get_block(
::astria_core::generated::astria::execution::v1::GetBlockRequest {
::astria_core::generated::astria::execution::v2::GetBlockRequest {
identifier: Some(identifier),
},
block,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ use std::{
};

use astria_core::generated::astria::{
execution::v1::{
execution::v2::{
execution_service_server::{
ExecutionService,
ExecutionServiceServer,
Expand Down
10 changes: 5 additions & 5 deletions crates/astria-conductor/tests/blackbox/helpers/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ use astria_conductor::{
use astria_core::{
brotli::compress_bytes,
generated::astria::{
execution::v1::{
execution::v2::{
Block,
CommitmentState,
GenesisInfo,
Expand Down Expand Up @@ -179,7 +179,7 @@ impl TestConductor {
pub async fn mount_get_block<S: serde::Serialize>(
&self,
expected_pbjson: S,
block: astria_core::generated::astria::execution::v1::Block,
block: astria_core::generated::astria::execution::v2::Block,
) {
use astria_grpc_mock::{
matcher::message_partial_pbjson,
Expand Down Expand Up @@ -311,7 +311,7 @@ impl TestConductor {
up_to_n_times: u64,
expected_calls: u64,
) {
use astria_core::generated::astria::execution::v1::GetGenesisInfoRequest;
use astria_core::generated::astria::execution::v2::GetGenesisInfoRequest;
astria_grpc_mock::Mock::for_rpc_given(
"get_genesis_info",
astria_grpc_mock::matcher::message_type::<GetGenesisInfoRequest>(),
Expand All @@ -328,7 +328,7 @@ impl TestConductor {
commitment_state: CommitmentState,
up_to_n_times: u64,
) {
use astria_core::generated::astria::execution::v1::GetCommitmentStateRequest;
use astria_core::generated::astria::execution::v2::GetCommitmentStateRequest;

astria_grpc_mock::Mock::for_rpc_given(
"get_commitment_state",
Expand Down Expand Up @@ -393,7 +393,7 @@ impl TestConductor {
commitment_state: CommitmentState,
expected_calls: impl Into<astria_grpc_mock::Times>,
) -> astria_grpc_mock::MockGuard {
use astria_core::generated::astria::execution::v1::UpdateCommitmentStateRequest;
use astria_core::generated::astria::execution::v2::UpdateCommitmentStateRequest;
use astria_grpc_mock::{
matcher::message_partial_pbjson,
response::constant_response,
Expand Down
2 changes: 1 addition & 1 deletion crates/astria-conductor/tests/blackbox/soft_only.rs
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ use astria_conductor::{
Conductor,
Config,
};
use astria_core::generated::astria::execution::v1::{
use astria_core::generated::astria::execution::v2::{
GetCommitmentStateRequest,
GetGenesisInfoRequest,
};
Expand Down
4 changes: 2 additions & 2 deletions crates/astria-core/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Add method `TracePrefixed::leading_channel` to read the left-most channel of
a trace prefixed ICS20 asset [#1768](https://github.com/astriaorg/astria/pull/1768).
- Add `impl Protobuf for Address<Bech32m>` [#1802](https://github.com/astriaorg/astria/pull/1802).
- Add v2 execution API, with notable changes to `astria_core::execution::v1::GenesisInfo`
to accomodate conductor stop height restart logic [#1928](https://github.com/astriaorg/astria/pull/1928).

### Changed

Expand All @@ -30,8 +32,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Update `idna` dependency to resolve cargo audit warning [#1869](https://github.com/astriaorg/astria/pull/1869).
- Replaced all instances of `[u8; 32]` by newtype
`astria_core::sequencerblock::v1::block::Hash` where appropriate [#1884](https://github.com/astriaorg/astria/pull/1884).
- Updated domain type `astria_core::execution::v1::GenesisInfo` to accomodate conductor
stop height restart logic; removed `GenesisInfo::sequencer_genesis_height` [#1928](https://github.com/astriaorg/astria/pull/1928).

### Removed

Expand Down
1 change: 1 addition & 0 deletions crates/astria-core/src/execution/mod.rs
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
pub mod v1;
pub mod v2;
Loading

0 comments on commit d8f2f3f

Please sign in to comment.