Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sequencer): Fix incorrect error message from BridgeUnlock actions #1505

Merged
merged 1 commit into from
Sep 17, 2024
Merged

fix(sequencer): Fix incorrect error message from BridgeUnlock actions #1505

merged 1 commit into from
Sep 17, 2024

Conversation

itamarreif
Copy link
Contributor

Summary

The error message for stateless checks on BridgeUnlock actions incorrectly states BridgeLock as the failing error.

Changes

  • change the error message that wraps the stateless check for BridgeUnlock actions

Related Issues

Link any issues that are related, prefer full github links.

closes #1465

@itamarreif itamarreif requested a review from a team as a code owner September 13, 2024 20:59
@itamarreif itamarreif requested a review from noot September 13, 2024 20:59
@github-actions github-actions bot added the sequencer pertaining to the astria-sequencer crate label Sep 13, 2024
@itamarreif itamarreif self-assigned this Sep 13, 2024
@itamarreif itamarreif added this pull request to the merge queue Sep 17, 2024
Merged via the queue into main with commit 1be156e Sep 17, 2024
42 checks passed
@itamarreif itamarreif deleted the itamarreif/sequencer/bridgeunlockmessage branch September 17, 2024 15:36
quasystaty1 pushed a commit that referenced this pull request Sep 17, 2024
@itamarreif @quasystaty1
fix(sequencer): Fix incorrect error message from BridgeUnlock actions (…
275139d 
…#1505)

The error message for stateless checks on `BridgeUnlock` actions
incorrectly states `BridgeLock` as the failing error.

- change the error message that wraps the stateless check for
`BridgeUnlock` actions

Link any issues that are related, prefer full github links.

closes #1465
quasystaty1 pushed a commit that referenced this pull request Sep 17, 2024
@itamarreif @quasystaty1
fix(sequencer): Fix incorrect error message from BridgeUnlock actions (…
2307695 
…#1505)

The error message for stateless checks on `BridgeUnlock` actions
incorrectly states `BridgeLock` as the failing error.

- change the error message that wraps the stateless check for
`BridgeUnlock` actions

Link any issues that are related, prefer full github links.

closes #1465
steezeburger added a commit that referenced this pull request Sep 23, 2024
@steezeburger
Merge branch 'main' into spike/noble-usdc
83f1643 
* main:
  feat(conductor): implement restart logic (#1463)
  fix: ignore `RUSTSEC-2024-0370` (#1483)
  fix, refactor(sequencer): refactor ics20 logic (#1495)
  fix(ci): use commit SHA instead of PR number preview-env images (#1501)
  chore(bridge-withdrawer): pass GRPC and CometBFT clients to consumers directly (#1510)
  fix(sequencer): Fix incorrect error message from BridgeUnlock actions (#1505)
  fix(bridge-contracts): fix memo transaction hash encoding (#1428)
  fix: build docker when workflow explicitly includes component (#1498)
  chore(sequencer): migrate from `anyhow::Result` to `eyre::Result` (#1387)
  fix(ci): typo for required field in sequencer preview-env (#1500)
  feat(ci): provide demo/preview environments (#1406)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joroshiba joroshiba joroshiba approved these changes

@noot noot Awaiting requested review from noot noot was automatically assigned from astriaorg/rust-reviewers

Assignees

@itamarreif itamarreif

Labels
sequencer pertaining to the astria-sequencer crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sequencer reports the wrong action as having failed
2 participants
@itamarreif @joroshiba