fix(ci): use commit SHA instead of PR number preview-env images #1501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aajimal
added
demo
evm
aajimal
changed the title
aajimal
force-pushed
the
preview-env-template-values
branch
from
23cf3b1 to
efc6d71
Compare
github-actions
bot
added
the
ci
aajimal
force-pushed
the
preview-env-template-values
branch
3 times, most recently
from
d4ae728 to
86e0b2e
Compare
aajimal
force-pushed
the
preview-env-template-values
branch
2 times, most recently
from
1f5a982 to
103eeaf
Compare
aajimal
force-pushed
the
preview-env-template-values
branch
from
103eeaf to
59f70f2
Compare
WafflesVonMaple
approved these changes
Sep 18, 2024
steezeburger
added a commit
that referenced
this pull request
Sep 23, 2024
* main: feat(conductor): implement restart logic (#1463) fix: ignore `RUSTSEC-2024-0370` (#1483) fix, refactor(sequencer): refactor ics20 logic (#1495) fix(ci): use commit SHA instead of PR number preview-env images (#1501) chore(bridge-withdrawer): pass GRPC and CometBFT clients to consumers directly (#1510) fix(sequencer): Fix incorrect error message from BridgeUnlock actions (#1505) fix(bridge-contracts): fix memo transaction hash encoding (#1428) fix: build docker when workflow explicitly includes component (#1498) chore(sequencer): migrate from `anyhow::Result` to `eyre::Result` (#1387) fix(ci): typo for required field in sequencer preview-env (#1500) feat(ci): provide demo/preview environments (#1406)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates preview environment manifests to use the exact commit sha when referencing artifacts to deploy (docker images). Also adds links in the GUI back to the PR and commit.
Background
This is to ensure that any subsequent updates to a PR will always result in the preview env looking for the rebuilt image (tagged with full commit hash) rather than assuming a cached one might be valid (e.g. tagged with PR number).This change is in addition to setting the imagePullPolicy to Always to make the configuration explicit.
Changes
Testing