Add filtering of interpreter names for tests with multiple Python versions #4368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
commented
Jun 17, 2024
Comment on lines
-196
to
+226
| .env("UV_TEST_PYTHON_PATH", "/dev/null") | ||
| .env("UV_TEST_PYTHON_PATH", &self.python_path()) |
There was a problem hiding this comment.
Using multiple Python versions is now "first class" so we can support filtering them.
zanieb
commented
Jun 17, 2024
| ); | ||
| for pattern in Self::path_patterns(executable) { | ||
| self.filters | ||
| .push_front((format!("{pattern}python.*"), format!("[PYTHON-{version}]"))); |
There was a problem hiding this comment.
These need to be in the front or they can get clobbered by other filters. Prompted the change to a double ended data structure.
|
This feels kind of sloppy but it's blocking work I want to release today. |
zanieb
force-pushed
the
zb/filter-create-venv
branch
from
b88dbfb to
7557c99
Compare
zanieb
force-pushed
the
zb/filter-python-versions
branch
2 times, most recently
from
0bbbc34 to
6e8cd33
Compare
zanieb
force-pushed
the
zb/filter-python-versions
branch
from
6e8cd33 to
c62101d
Compare
zanieb
added a commit
that referenced
this pull request
Jun 18, 2024
It was becoming problematic that the virtual environment test context diverged from the other one i.e. we had to implement filtering twice. This combines the contexts and tweaks the `TestContext` API and filtering mechanisms for Python versions. Combined with my previous changes to the test context at #4364 and #4368 this finally unblocks the snapshots for test cases in #4360 and #4362.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends new filters for interpreter paths to apply to tests with multiple Python versions. Adds patch version filtering for them as well, which is needed for #4360 tests.