Add filtering of the test context Python interpreter #4364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does not handle tests with multiple Python versions yet, workingon that separately because the change is more invasive
ibraheemdev
approved these changes
Jun 17, 2024
zanieb
added a commit
that referenced
this pull request
Jun 17, 2024
Extends #4364 automatically adding filters to the test context for additional test virtual environments. It turns out that the `pip sync` tests were really on the loose with their virtual environment creation and it was difficult to use the new helpers because they require mutability and the tests had immutable borrows to extend the filters 😭. I refactored the tests to just reset the environment.
zanieb
added a commit
that referenced
this pull request
Jun 18, 2024
It was becoming problematic that the virtual environment test context diverged from the other one i.e. we had to implement filtering twice. This combines the contexts and tweaks the `TestContext` API and filtering mechanisms for Python versions. Combined with my previous changes to the test context at #4364 and #4368 this finally unblocks the snapshots for test cases in #4360 and #4362.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does not handle tests with multiple Python versions yet, working on that separately because the change is more invasive