URL decode passwords for storage #2947
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
commented
Apr 9, 2024
| username: urlencoding::decode(url.username()) | ||
| .expect("An encoded username should always decode") | ||
| .into_owned(), | ||
| password: url.password().map(str::to_string), | ||
| password: url.password().map(|password| { |
There was a problem hiding this comment.
url.password() is explicitly a percent-encoded string so this makes a lot of sense to me.
|
I think the problem is roughly that we use uv/crates/uv-auth/src/store.rs Lines 47 to 55 in 43ded54 but those percent-encode the credentials which are already be percent-encoded since we pulled from from I want to make some changes to the documentation and structs here to clarify this. |
charliermarsh
approved these changes
Apr 9, 2024
Merged
|
Implemented in #2976 |
zanieb
added a commit
that referenced
this pull request
Apr 16, 2024
Closes - #2822 - #2563 (via #2984) Partially address: - #2465 - #2464 Supersedes: - #2947 - #2570 (via #2984) Some significant refactors to the whole `uv-auth` crate: - Improving the API - Adding test coverage - Fixing handling of URL-encoded passwords - Fixing keyring authentication - Updated middleware (see #2984 for more)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2822
Same idea as #2592
Needs a test plan still.