Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit test coverage for netrc authentication #2465

Closed
zanieb opened this issue Mar 14, 2024 · 3 comments · Fixed by #3068
Closed

Add unit test coverage for netrc authentication #2465

zanieb opened this issue Mar 14, 2024 · 3 comments · Fixed by #3068
Labels
help wanted Contribution especially encouraged registry Related to package indexes and registries testing Internal testing of behavior

Comments

@zanieb
Copy link
Member

zanieb commented Mar 14, 2024

Similar to #2447 — but we should use a netrc file instead of in-url authentication.

We'll probably need to configure netrc to use a file in a temporary directory. We don't want this to affect the developer's machine.
@zanieb zanieb added testing Internal testing of behavior help wanted Contribution especially encouraged registry Related to package indexes and registries labels Mar 14, 2024
@bschoenmaeckers
Copy link
Contributor

Is this test not sufficient to validate netrc authentication? Or do we need more tests to validate correct precedence?

@zanieb
Copy link
Member Author

zanieb commented Mar 14, 2024

It's not sufficient because it does doesn't ensure we're properly applying authentication to all the requests necessary for installation. I'm looking for something that's end-to-end like #2463

This was referenced Apr 12, 2024
Merged
Merged
zanieb added a commit that referenced this issue Apr 16, 2024
@zanieb
Rewrite uv-auth (#2976)
c0efeed 
Closes 

- #2822 
- #2563 (via #2984)

Partially address:

- #2465
- #2464

Supersedes:

- #2947
- #2570 (via #2984)

Some significant refactors to the whole `uv-auth` crate:

- Improving the API
- Adding test coverage
- Fixing handling of URL-encoded passwords
- Fixing keyring authentication
- Updated middleware (see #2984 for more)
@zanieb
Copy link
Member Author

zanieb commented Apr 16, 2024

We have more test coverage in #2976 now but still not end-to-end.

@zanieb zanieb mentioned this issue Apr 16, 2024
Merged
zanieb added a commit that referenced this issue Apr 17, 2024
@zanieb
Add integration test coverage for netrc authentication (#3068)
01532d9 
Closes #2465
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Contribution especially encouraged registry Related to package indexes and registries testing Internal testing of behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add integration test coverage for netrc authentication astral-sh/uv
2 participants
@zanieb @bschoenmaeckers