Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Black tests #8901

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Update Black tests #8901

merged 1 commit into from
Nov 30, 2023

Conversation

MichaReiser
Copy link
Member

@MichaReiser MichaReiser commented Nov 29, 2023 •
edited
Loading

Summary

Updates all black tests. Black centralized their tests into the cases directory which is why we see many moved test files.

There's one unstable test. I commented it out for now and created an issue to investigate the formatting.

Test Plan

cargo test

@MichaReiser
Copy link
Member Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 29, 2023 •
edited
Loading

ruff-ecosystem results

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

@MichaReiser MichaReiser force-pushed the update-black-tests branch 2 times, most recently from 67f38ba to d22962f Compare November 29, 2023 06:53
@MichaReiser MichaReiser added the internal An internal refactor or improvement label Nov 29, 2023
@MichaReiser MichaReiser marked this pull request as ready for review November 29, 2023 07:03
@MichaReiser MichaReiser force-pushed the update-black-tests branch 2 times, most recently from 42c9553 to eb78adf Compare November 29, 2023 07:22
konstin
konstin approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@konstin konstin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this

@MichaReiser MichaReiser merged commit fd70cd7 into main Nov 30, 2023
@MichaReiser MichaReiser deleted the update-black-tests branch November 30, 2023 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charliermarsh charliermarsh charliermarsh approved these changes

@konstin konstin konstin approved these changes

Assignees
No one assigned
Labels
internal An internal refactor or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MichaReiser @charliermarsh @konstin