Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unstable formatting in ignore_pyi.pyi #8905

Closed
MichaReiser opened this issue Nov 29, 2023 · 0 comments · Fixed by #8984
Closed

Unstable formatting in ignore_pyi.pyi #8905

MichaReiser opened this issue Nov 29, 2023 · 0 comments · Fixed by #8984
Assignees
@charliermarsh
Labels
bug Something isn't working formatter Related to the formatter help wanted Contributions especially welcome
Milestone
Formatter: Stable

Comments

@MichaReiser
Copy link
Member 

def h():
    ...
    # bye

in ignore_pyi.pyi leads to unstable formatting.
@MichaReiser MichaReiser added bug Something isn't working formatter Related to the formatter labels Nov 29, 2023
@MichaReiser MichaReiser added this to the Formatter: Stable milestone Nov 29, 2023
@MichaReiser MichaReiser added the help wanted Contributions especially welcome label Nov 29, 2023
@MichaReiser MichaReiser mentioned this issue Nov 29, 2023
Merged
@charliermarsh charliermarsh self-assigned this Dec 3, 2023
@charliermarsh charliermarsh mentioned this issue Dec 3, 2023
Merged
charliermarsh added a commit that referenced this issue Dec 4, 2023
@charliermarsh
Avoid unstable formatting in ellipsis-only body with trailing comment (…
6fe8f8a 
…#8984)

## Summary

We should avoid inlining the ellipsis in:

```python
def h():
    ...
    # bye
```

Just as we omit the ellipsis in:

```python
def h():
    # bye
    ...
```

Closes #8905.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charliermarsh charliermarsh

Labels
bug Something isn't working formatter Related to the formatter help wanted Contributions especially welcome
Projects
None yet
Milestone
Formatter: Stable
Development

Successfully merging a pull request may close this issue.

Avoid unstable formatting in ellipsis-only body with trailing comment astral-sh/ruff
2 participants
@MichaReiser @charliermarsh