Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-align RadioListItem button to top of component #769

Merged
merged 2 commits into from
May 24, 2020

Conversation

stvtortora
Copy link
Contributor

@stvtortora stvtortora commented May 19, 2020

@welcome
Copy link

welcome bot commented May 19, 2020

Thanks for opening this pull request! Someone will review it soon 🔍

@CLAassistant
Copy link

CLAassistant commented May 19, 2020

CLA assistant check
All committers have signed the CLA.

@auto-assign auto-assign bot requested a review from bpierre May 19, 2020 01:54
@stvtortora
Copy link
Contributor Author

Hi, any update on this one?

@bpierre
Copy link
Contributor

bpierre commented May 22, 2020

Hi @stvtortora, sorry for the delay, I am checking now.

I noticed the spacing wasn’t exactly the same as the Figma file (1px vs. 4px). The default on Radio is 4px already, so I think we could remove the line altogether?

@bpierre bpierre mentioned this pull request May 22, 2020
2 tasks
@stvtortora
Copy link
Contributor Author

Hi @bpierre. No worries. I removed that line, but I don't think its what we want because no default value took its place. As far as I can tell, there does not appears to be a file (or any code for that matter) with "Figma" in this repository.

@bpierre
Copy link
Contributor

bpierre commented May 23, 2020

As far as I can tell, there does not appears to be a file (or any code for that matter) with "Figma" in this repository.

Ah sorry I should have been more explicit, I was referring to the link to Figma in the issue: https://www.figma.com/file/bZ1j7omfhdMCbtFahP3nEJ9B/Client?node-id=525%3A1141

I was just testing and it seems correct now?

@stvtortora
Copy link
Contributor Author

@bpierre Ah, ok, thanks for clarifying! It looks good to me too.

Copy link
Contributor

@bpierre bpierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@bpierre bpierre merged commit c6b4c6b into aragon:master May 24, 2020
@welcome
Copy link

welcome bot commented May 24, 2020

Congrats on merging your first pull request! Aragon is proud of you 🦅 Eagle gif

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RadioList style update
3 participants