-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RadioList style update #1340
Comments
Could add more information? Is the only difference between them the icon? What is the goal here? |
@iwaduarte The main difference is the positioning of the radio against its label; currently it's center, in the new version it should be at the top. There are two steps:
|
@sohkai I understand. Althoug I am afraid to put my efforts and time and not have another PR merged into the platform. I have seen that you guys have a very long list of PRs that are not merged. Probably that is not your main job either but very unusual time frame indeed. |
Yes understood @iwaduarte, and thanks for the feedback. We are working on this on an organizational level so that we can:
|
hi, I want to start contributing. Is anyone working on this issue? |
@stvtortora Thanks for offering your help! I don’t think anyone is on this issue, feel free to grab it. 🚀 |
It appears that a PR was merged to solve this. Any reason it's still open? I'm looking for some issues to contribute. |
@mauerv Yes, we still need to add a |
Hey, i want to fix the App badge but can't find the component |
Hey @etherean06, the mentioned AppBadge component would be added to the SignerPanel, but we're actually in the process of removing this side panel altogether with a different design that will alleviate the need to add an Since we're doing this in #1465, I'll close this issue here. |
Current version:
New version:
Figma reference: https://www.figma.com/file/bZ1j7omfhdMCbtFahP3nEJ9B/Client?node-id=0%3A1
Tasks
AppBadge
inside of theRadioList
.The text was updated successfully, but these errors were encountered: