Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RadioList style update #1340

Closed
1 of 2 tasks
bpierre opened this issue Mar 6, 2020 · 10 comments · Fixed by aragon/ui#769
Closed
1 of 2 tasks

RadioList style update #1340

bpierre opened this issue Mar 6, 2020 · 10 comments · Fixed by aragon/ui#769

Comments

@bpierre
Copy link
Contributor

bpierre commented Mar 6, 2020

Current version:

New version:

Figma reference: https://www.figma.com/file/bZ1j7omfhdMCbtFahP3nEJ9B/Client?node-id=0%3A1

Tasks

@iwaduarte
Copy link
Contributor

Could add more information? Is the only difference between them the icon? What is the goal here?
Should I fork them the aragon-ui and edit the component add this props? Why is the issue in this repo then?

@sohkai
Copy link
Contributor

sohkai commented Mar 19, 2020

@iwaduarte The main difference is the positioning of the radio against its label; currently it's center, in the new version it should be at the top.

There are two steps:

  1. Fork and edit this component in aragonUI
  2. Update this repo with the new version, and make sure nothing breaks. Updating the SignerPanel to have an AppBadge would be even better :).

@iwaduarte
Copy link
Contributor

@sohkai I understand. Althoug I am afraid to put my efforts and time and not have another PR merged into the platform. I have seen that you guys have a very long list of PRs that are not merged.
I have also just recently PR a very simple issue and although it seems okay (issue approved) I have not heard of anyone for merging or anything like that.

Probably that is not your main job either but very unusual time frame indeed.

@sohkai
Copy link
Contributor

sohkai commented Mar 20, 2020

Yes understood @iwaduarte, and thanks for the feedback. We are working on this on an organizational level so that we can:

  1. Reduce the number of unmerged PRs
  2. Decrease the time it takes for a PR to be merged

@stvtortora
Copy link

hi, I want to start contributing. Is anyone working on this issue?

@bpierre
Copy link
Contributor Author

bpierre commented May 18, 2020

@stvtortora Thanks for offering your help! I don’t think anyone is on this issue, feel free to grab it. 🚀

@mauerv
Copy link

mauerv commented Jun 16, 2020

It appears that a PR was merged to solve this. Any reason it's still open? I'm looking for some issues to contribute.

@bpierre
Copy link
Contributor Author

bpierre commented Jun 16, 2020

@mauerv Yes, we still need to add a AppBadge inside the RadioList. Do you want to work on it? 🙂

@ghost
Copy link

ghost commented Jul 10, 2020

Hey, i want to fix the App badge but can't find the component

@sohkai
Copy link
Contributor

sohkai commented Jul 11, 2020

Hey @etherean06, the mentioned AppBadge component would be added to the SignerPanel, but we're actually in the process of removing this side panel altogether with a different design that will alleviate the need to add an AppBadge here!

Since we're doing this in #1465, I'll close this issue here.

@sohkai sohkai closed this as completed Jul 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants