-
Notifications
You must be signed in to change notification settings - Fork 874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gradle options UI cleanup (Execution and Appearance panel). #5274
Conversation
5eac923
to
c5f5db3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mbien Thanks for this PR. Generally it looks good. I'd leave out the Prefer Maven Projects check box out of Gradle Execution as that is really an IDE behavior.When a folder has pom.xml
next to gradle build files, then the GradleProjectFactory
let's MavenProjectFactory
to take over.
I would put that as a distinct option at the bottom right corner.
c5f5db3
to
0ff35f3
Compare
@lkishalmi tbh I don't quite like how this looks. Can I wrap this into an "Other Options" panel? |
0ff35f3
to
5e49165
Compare
Well, I actually like the first new version. The second one looks too much for me. There might be other new options in that area... |
The prefer Maven over Gradle option really isn't an option of Maven or Gradle. It needs to be in a more general location, possibly on the general tab, even though (currently) these are Java-related. Shouldn't Ant also be included? We need an order list of how they should be prioritized. Theoretically Gradle projects can support C++ as well so if that was ever pursued things could get messier still. |
I only wanted to fix some layout issues in the UI, consistent gaps, resizing etc, Moving things around to entirely different option panels would be more than just layout adjustments and something for another PR. |
@swpalmer That would be a major re-arch. We should create a Build Tools section in the Options Dialog. |
- consistent gaps and component anchors - moved a few options to the global exec group
5e49165
to
34f9d49
Compare
@lkishalmi updated the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now.
apache#5274 overlooked an invisible label which is only visible if an unsupported version is selected in the combo box. This fixes the layout so that making the label visible does not disturb other UI components.
please note that the before screenshots are actually NB 16 and not master. So they have 1-2 fields less.
before (checkboxes in upper panel are all over the place + panel gaps + some exec options not in the lower panel):

after:

before (left gaps on checkboxes):

after (note: new Maven):
