Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve padding size in the "Options" dialog #4973

Closed
bykka opened this issue Nov 16, 2022 · 6 comments · Fixed by #5625
Closed

Improve padding size in the "Options" dialog #4973

bykka opened this issue Nov 16, 2022 · 6 comments · Fixed by #5625
Labels
kind:feature A feature request Look and Feel os:windows UI User Interface

Comments

@bykka
Copy link

bykka commented Nov 16, 2022

Description

The "Options" dialog does not look polished and one of the problems is that components have different padding sizes.
Or sometimes does not have padding at all.

  • different padding
    image
    image
    image
    image
  • no top padding
    image
  • different padding
    image
    image
  • no bottom padding and unnecessary resize bar
    image
  • different top padding
    image

Use case/motivation

Would to see a consistent design for all tabs of the "Options" dialog.

Related issues

No response

Are you willing to submit a pull request?

No

Code of Conduct

Yes

@bykka bykka added kind:feature A feature request needs:triage Requires attention from one of the committers labels Nov 16, 2022
@neilcsmith-net neilcsmith-net added good first issue Contribution welcome An issue or feature not currently being worked on, but a contribution would be welcomed! and removed needs:triage Requires attention from one of the committers labels Nov 16, 2022
@neilcsmith-net
Copy link
Member

Some good points made (except possibly for the resize bar - actually found myself needing that this week). Stuck good first issue on it, as it might be an interesting issue for a new contributor with good visible outcomes.

@mbien
Copy link
Member

mbien commented Nov 17, 2022

what look and feel are you using? FlatLaf won't render many of the borders on the screenshots which makes this issue less visible. In some situations adding padding without borders might leave too large gaps (e.g I don't think the hints tab needs more padding in the north with FlatLaf since there is no border). We might have to set null border in some places.

NB16 should have a more consistent looking hints tab (with all its option panels) #4906.

@bykka
Copy link
Author

bykka commented Nov 17, 2022

Windows L&F
image

@mbien
Copy link
Member

mbien commented Nov 17, 2022

right. FlatLaf became the default on all systems a few releases ago. We mostly pay attention that everything is working well on the default.

But fixes for other look and feels are of course welcome too as long they don't affect the default. Most of the layout issues you marked do also apply to FlatLaf.

@mbien mbien added the UI User Interface label Jan 12, 2023
@mbien
Copy link
Member

mbien commented Jan 12, 2023

gradle options UI cleanup: #5274

@mbien
Copy link
Member

mbien commented Mar 8, 2023

@bykka #5625 should fix this + more. A dev build will appear on the summary page of the PR workflow.

@mbien mbien removed good first issue Contribution welcome An issue or feature not currently being worked on, but a contribution would be welcomed! labels Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:feature A feature request Look and Feel os:windows UI User Interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants