[INLONG-5074][Sort] KafkaExtractNode support more StartupMode #5079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thanks a lot for your contribution! 💖 This seems to be your first PR! 🌠 Please be sure to follow our contribution guidelines! 🎁
healchow
reviewed
Jul 16, 2022
...rt/sort-common/src/main/java/org/apache/inlong/sort/protocol/enums/KafkaScanStartupMode.java
Outdated
Show resolved
Hide resolved
|
@yunqingmoswu @EMsnap PTAL, tks. |
|
@huyuanfeng2018 Hello, there are some conflicts, and the |
yunqingmoswu
approved these changes
Jul 16, 2022
It is all right after handling the comment. |
huyuanfeng2018
force-pushed
the
INLONG-5074
branch
from
f50a248 to
88d1030
Compare
Hi, I have resolved the conflict and added the Apache Licence header to the test class, please have a look again, thanks |
huyuanfeng2018
force-pushed
the
INLONG-5074
branch
from
88d1030 to
57cd2f4
Compare
gong
approved these changes
Jul 17, 2022
healchow
requested changes
Jul 18, 2022
...ger-common/src/main/java/org/apache/inlong/manager/common/pojo/source/kafka/KafkaSource.java
Outdated
Show resolved
Hide resolved
...g-sort/sort-common/src/main/java/org/apache/inlong/sort/protocol/constant/KafkaConstant.java
Outdated
Show resolved
Hide resolved
...rt/sort-common/src/main/java/org/apache/inlong/sort/protocol/enums/KafkaScanStartupMode.java
Outdated
Show resolved
Hide resolved
...sort-common/src/main/java/org/apache/inlong/sort/protocol/node/extract/KafkaExtractNode.java
Outdated
Show resolved
Hide resolved
EMsnap
reviewed
Jul 18, 2022
...sort-common/src/main/java/org/apache/inlong/sort/protocol/node/extract/KafkaExtractNode.java
Outdated
Show resolved
Hide resolved
thesumery
approved these changes
Jul 18, 2022
huyuanfeng2018
force-pushed
the
INLONG-5074
branch
from
57cd2f4 to
6edd0fa
Compare
healchow
approved these changes
Jul 18, 2022
dockerzhang
approved these changes
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare a Pull Request
[INLONG-5074][Sort] KafkaExtractNode support more StartupMode
Fixes [Improve][Sort] KafkaExtractNode support more StartupMode #5074
Motivation
KafkaExtractNode supports consumption from specified partitions and offsets
Verifying this change