Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][Sort] KafkaExtractNode support more StartupMode #5074

Closed
2 tasks done
huyuanfeng2018 opened this issue Jul 15, 2022 · 3 comments · Fixed by #5079
Closed
2 tasks done

[Improve][Sort] KafkaExtractNode support more StartupMode #5074

huyuanfeng2018 opened this issue Jul 15, 2022 · 3 comments · Fixed by #5079
Assignees
Milestone

Comments

@huyuanfeng2018
Copy link
Contributor

Description

Written variously: I think KafkaExtractNode should support more KafkaScanStartupMode. Currently, only two types of KafkaExtractNode are supported, including EARLIEST_OFFSET and LATEST_OFFSET, But in many cases topicPartitionOffset is specified, and this parameter is already reserved in KafkaSource,I'd like to contribute this code if I can

InLong Component

InLong Sort

Are you willing to submit PR?

  • Yes, I am willing to submit a PR!

Code of Conduct

@github-actions
Copy link

Thanks a lot for opening your first issue with us! 🧡 We'll get back to you shortly! ⏳

@EMsnap EMsnap added this to the 1.3.0 milestone Jul 15, 2022
@EMsnap
Copy link
Contributor

EMsnap commented Jul 15, 2022

Yeah sure, thanks for participation, note that now SPECIFIC_OFFSETS is currently support by KafkaDynamicTableFactory. Please be aware of that the specificStartupOffsets should also be passed to the factory when doing so

@huyuanfeng2018
Copy link
Contributor Author

I want to do this @dockerzhang

Yeah sure, thanks for participation, note that now SPECIFIC_OFFSETS is currently support by KafkaDynamicTableFactory. Please be aware of that the specificStartupOffsets should also be passed to the factory when doing so

Ok, I'll take care of that

@huyuanfeng2018 huyuanfeng2018 changed the title [Improve] KafkaExtractNode support more StartupMode [Improve][Sort] KafkaExtractNode support more StartupMode Jul 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants