Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include struct name on FileScanConfig debug impl #14883

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Feb 25, 2025

Which issue does this PR close?

Part of

Rationale for this change

When working on upgrading delta-rs to use the new DataSourceExec I was super confused that the source printed out like this

object_store_url=...

Without the struct name 🤯

What changes are included in this PR?

Add the struct name

Are these changes tested?

Are there any user-facing changes?

Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks @alamb

@comphead comphead merged commit f5b7aff into apache:main Feb 26, 2025
26 checks passed
@alamb
Copy link
Contributor Author

alamb commented Feb 26, 2025

Thank you @comphead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants