Require Debug for DataSource
#14882
Merged
Require Debug for DataSource
#14882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Feb 25, 2025
| @@ -35,7 +35,7 @@ use datafusion_physical_expr_common::sort_expr::LexOrdering; | |||
|
|
|||
| /// Common behaviors in Data Sources for both from Files and Memory. | |||
| /// See `DataSourceExec` for physical plan implementation | |||
| pub trait DataSource: Send + Sync { | |||
| pub trait DataSource: Send + Sync + Debug { | |||
There was a problem hiding this comment.
this means that anything that implements DataSource must also implement Debug
This trait was introduced in
And thus has not yet been released yet and thus is not a breaking change
comphead
reviewed
Feb 26, 2025
| @@ -35,7 +35,7 @@ use datafusion_physical_expr_common::sort_expr::LexOrdering; | |||
|
|
|||
| /// Common behaviors in Data Sources for both from Files and Memory. | |||
| /// See `DataSourceExec` for physical plan implementation | |||
| pub trait DataSource: Send + Sync { | |||
| pub trait DataSource: Send + Sync + Debug { | |||
There was a problem hiding this comment.
probably we can comment why Debug is required? 🤔
There was a problem hiding this comment.
Added a note in a5dbaca-- the real reason is to help standard debugging.
comphead
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of
46.0.0#14123This is a follow on / fallout of
DataSourceExecfor provided datasources, removeParquetExec,CsvExec, etc #14224Rationale for this change
When working on upgrading delta-rs to use the new DataSourceExec I was debugging something and all that is shown is like this
I want to be able to see what DataSource it is so I can debug it properly
What changes are included in this PR?
DebugforDataSourceAre these changes tested?
By CI
Are there any user-facing changes?
Better debug ability
I have more improvements planned in this area too as I work through the delta upgrade