Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: an empty operation name causes the error in the redis-client library (dependency of Redis gem). Only relevant to Redis v5.
Reason:
Let's check the path from the
graphql-anycable
toredis-client
:data
hash with theoperation_name
key;operation_name
can be nil, because it's not a required attribute, and a subscription without a name is still valid;graphql-anycable
passes thedata
hash via themapped_hmset
method;mapped_hmset
sendsHMSET
command viaredis_client
;redis_client
checks the attributes here and triggers the error because one of the attributes (operation_name
) is nil.Here you can find a reason why
redis-client
doesn't support nil.The issue is reproducible with Redis v5, you can remove the fix and the following error will be triggered in spec: