Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better config.use_client_provided_uniq_id deprecation #27

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

gsamokovarov
Copy link
Contributor

Moving this warning to the invocation of GraphQL::AnyCable.use makes it issuable outside of Rails, as suggested by @palkan.

Moving this warning to the invocation of `GraphQL::AnyCable.use` makes
it issuable outside of Rails.
Copy link
Member

@palkan palkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@Envek Envek merged commit bad0a15 into anycable:master Oct 26, 2022
Envek pushed a commit that referenced this pull request Oct 26, 2022
Moving this warning to the invocation of `GraphQL::AnyCable.use` makes
it issuable outside of Rails.
@Envek
Copy link
Member

Envek commented Oct 26, 2022

Sorry, just got to it. Released in 1.1.5

@gsamokovarov gsamokovarov deleted the better-deprecation-warning branch October 27, 2022 19:13
Envek added a commit that referenced this pull request May 7, 2024
…dling

* master:
  Switch to RubyGems Trusted publishing in CI release workflow [ci skip]
  add emergency actions TO README
  fix: consider redis_prefix in GraphQL::AnyCable::Cleaner
  add ability to set scan_count and added a little refactoring
  ability to fetch subscription stats
  use "around" instead "before"
  little refactoring
  add changes to README
  remove override redis_prefix and add an extra spec
  feat: Add configurable graphql redis_prefix
  Support empty operation name with redis.rb v5 (#34)
  Use arrays to fix deprecation warnings with redis gem 4.8 (#29)
  Use real Redis in tests instead of fakeredis gem (#32)
  Better `config.use_client_provided_uniq_id` deprecation (#27)
  Delay the deprecation warning of use_client_provided_uniq_id (#26)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants