fix governance proposal execution #3087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3087 +/- ##
==========================================
+ Coverage 59.39% 59.42% +0.02%
==========================================
Files 298 298
Lines 92771 92762 -9
==========================================
+ Hits 55104 55122 +18
+ Misses 37667 37640 -27 ☔ View full report in Codecov by Sentry. |
added 2 commits
April 16, 2024 17:05
Fraccaman
commented
Apr 16, 2024
Comment on lines
+84
to
+98
| // Is VP triggered by a governance proposal? | ||
| let is_governance_proposal = is_proposal_accepted( | ||
| &self.ctx.pre(), | ||
| tx_data.data().unwrap_or_default().as_ref(), | ||
| ) | ||
| .unwrap_or_default(); | ||
|
|
||
| let native_token = self.ctx.pre().get_native_token()?; | ||
|
|
||
| // Find the actions applied in the tx | ||
| let actions = self.ctx.read_actions()?; | ||
|
|
||
| // There must be at least one action if any of the keys belong to gov | ||
| if actions.is_empty() | ||
| if !is_governance_proposal | ||
| && actions.is_empty() |
There was a problem hiding this comment.
@tzemanovic I had to add this condition
Closed
brentstone
approved these changes
Apr 18, 2024
brentstone
added a commit
that referenced
this pull request
Apr 18, 2024
* fraccaman/fix-governance-proposal-execution: changelog: add #3087 end voting once the voting end epoch begins remove print fix governance proposal execution fix governance proposal execution
brentstone
added a commit
that referenced
this pull request
Apr 18, 2024
* fraccaman/fix-governance-proposal-execution: changelog: add #3087 end voting once the voting end epoch begins remove print fix governance proposal execution fix governance proposal execution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Indicate on which release or other PRs this topic is based on
Checklist before merging to
draft