-
Notifications
You must be signed in to change notification settings - Fork 993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MASP VP should support governance changes #3068
Comments
We need to do this in phase 1 so we can test the phase transitions. |
@murisi do you know how long this will take? any chance you could do it quickly? |
I expect this to take maybe 2 or 3 days. I'd already started on making the MASP VP more similar to other VPs. And I don't see why allowing the MASP asset map to be changed should be difficult. |
Any chance we could prioritize this, especially for next release? I ask because we have an e2e test |
After #2601, governance proposals are allowed to change the asset map of masp for the conversions. At the moment though, the masp vp rejects these changes. We need to update it to support proposals.
In doing so, we could also refactor the VP itself to iterate on the keys as variants of an enum
KeyType
to make it more similar to the other VPs we have.The text was updated successfully, but these errors were encountered: