Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MASP VP should support governance changes #3068

Closed
grarco opened this issue Apr 11, 2024 · 4 comments · Fixed by #3264
Closed

MASP VP should support governance changes #3068

grarco opened this issue Apr 11, 2024 · 4 comments · Fixed by #3264

Comments

@grarco
Copy link
Collaborator

grarco commented Apr 11, 2024

After #2601, governance proposals are allowed to change the asset map of masp for the conversions. At the moment though, the masp vp rejects these changes. We need to update it to support proposals.

In doing so, we could also refactor the VP itself to iterate on the keys as variants of an enum KeyType to make it more similar to the other VPs we have.

@cwgoes
Copy link
Collaborator

cwgoes commented Apr 24, 2024

We need to do this in phase 1 so we can test the phase transitions.

@cwgoes
Copy link
Collaborator

cwgoes commented Apr 24, 2024

@murisi do you know how long this will take? any chance you could do it quickly?

@murisi
Copy link
Collaborator

murisi commented Apr 25, 2024

@murisi do you know how long this will take? any chance you could do it quickly?

I expect this to take maybe 2 or 3 days. I'd already started on making the MASP VP more similar to other VPs. And I don't see why allowing the MASP asset map to be changed should be difficult.

@brentstone
Copy link
Collaborator

Any chance we could prioritize this, especially for next release? I ask because we have an e2e test proposal_ibc_token_inflation that is failing without this, and don't want to be in the dark about that for too long. @murisi

@grarco grarco linked a pull request May 11, 2024 that will close this issue
2 tasks
@grarco grarco removed a link to a pull request May 13, 2024
2 tasks
@grarco grarco linked a pull request May 14, 2024 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment