Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove summary styling from govspeak #2447

Merged
merged 1 commit into from
Nov 16, 2021
Merged

Remove summary styling from govspeak #2447

merged 1 commit into from
Nov 16, 2021

Conversation

owenatgov
Copy link
Contributor

What

Removes the styling for the govspeak summary extension as well as the associated docs

Why

Fixes #598

To summarise (🥁 ):

  • The summary extension has been retired so we shouldn't include this in the gem
  • This styling has no impact on the user in practice compared to if the markup was just presented to the user without the wrapping div

No visual changes

@govuk-ci govuk-ci temporarily deployed to components-gem-pr-2447 November 12, 2021 16:21 Inactive
@owenatgov owenatgov force-pushed the remove-summary-styling-from-govspeak branch from 2c59b53 to 1b3f0e4 Compare November 12, 2021 16:21
@owenatgov owenatgov marked this pull request as ready for review November 12, 2021 16:22
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-2447 November 12, 2021 16:22 Inactive
jon-kirwan
jon-kirwan approved these changes Nov 15, 2021
View reviewed changes
Copy link
Contributor

@jon-kirwan jon-kirwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥 all good (just the CHANGELOG conflict to be resolved here too)

@owenatgov owenatgov force-pushed the remove-summary-styling-from-govspeak branch from 1b3f0e4 to 7dbdfe7 Compare November 16, 2021 09:36
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-2447 November 16, 2021 09:36 Inactive
@owenatgov owenatgov mentioned this pull request Nov 16, 2021
Open
@owenatgov owenatgov merged commit e924caa into master Nov 16, 2021
@owenatgov owenatgov deleted the remove-summary-styling-from-govspeak branch November 16, 2021 09:41
@owenatgov owenatgov mentioned this pull request Nov 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jon-kirwan jon-kirwan jon-kirwan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Govspeak Summary is deprecated
3 participants
@owenatgov @jon-kirwan @govuk-ci