Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor watch task to remove gulp.watch() #3428

Closed
wants to merge 2 commits into from
Closed

Refactor watch task to remove gulp.watch() #3428

wants to merge 2 commits into from

Conversation

colinrotherham
Copy link
Contributor

@colinrotherham colinrotherham commented Mar 28, 2023 •
edited
Loading

Closes #2707 with most work coming from:

I've directly imported chokidar which gulp.watch() uses, but would Browsersync be more useful?

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3428 March 28, 2023 13:01 Inactive
@colinrotherham colinrotherham linked an issue Mar 28, 2023 that may be closed by this pull request
Refactor watch task to remove Gulp #2707
Closed
3 tasks
@colinrotherham colinrotherham force-pushed the build-tasks-gulpfile-app branch from 396f0fc to 5a458ac Compare March 28, 2023 13:36
@colinrotherham colinrotherham requested a review from a team as a code owner March 28, 2023 13:36
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3428 March 28, 2023 13:42 Inactive
@colinrotherham colinrotherham force-pushed the build-tasks-gulpfile-app branch 5 times, most recently from 7b5fc1e to a47ebdb Compare March 29, 2023 21:59
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3428 March 30, 2023 06:41 Inactive
@colinrotherham colinrotherham force-pushed the build-tasks-gulpfile-app branch 3 times, most recently from 7887cab to 69b3f08 Compare March 30, 2023 19:07
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3428 March 30, 2023 19:12 Inactive
Base automatically changed from build-tasks-gulpfile-app to main March 30, 2023 19:13
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3428 March 31, 2023 10:32 Inactive
@colinrotherham colinrotherham changed the title Refactor watch task to remove Gulp Refactor watch task to remove gulp.watch() Mar 31, 2023
@colinrotherham
Copy link
Contributor Author

I've added another commit to this one to restore gulp.parallel() for CLI logging purposes like we did in:

@colinrotherham colinrotherham mentioned this pull request Mar 31, 2023
Closed
3 tasks
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3428 April 3, 2023 14:19 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3428 April 3, 2023 20:25 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3428 April 11, 2023 11:01 Inactive
@colinrotherham
Copy link
Contributor Author

Going to close this one following the discussion on #2707

We've now decided to keep a lot more of Gulp than when the PR was first created

@colinrotherham colinrotherham deleted the ungulp-watch branch May 4, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor watch task to remove Gulp
2 participants
@colinrotherham @govuk-design-system-ci