Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor watch task to remove Gulp #2707

Closed
2 of 3 tasks
domoscargin opened this issue Jul 20, 2022 · 4 comments
Closed
2 of 3 tasks

Refactor watch task to remove Gulp #2707

domoscargin opened this issue Jul 20, 2022 · 4 comments
Labels
🕔 hours A well understood issue which we expect to take less than a day to resolve. tooling

Comments

@domoscargin
Copy link
Contributor

domoscargin commented Jul 20, 2022

What

Update tasks/gulp/watch.js to replace Gulp with our own watch script. This task is responsible for watching source code changes.

Why

We have made the decision to move away from Gulp and write our own build scripts.

Who needs to work on this

Developers

Who needs to review this

Developers

Done when

  • tasks/gulp/watch.js no longer depends on Gulp
  • docs/contributing/tasks.md has been updated
  • watch.js has been relocated to tasks folder
@domoscargin domoscargin added 🕔 hours A well understood issue which we expect to take less than a day to resolve. tooling javascript squad labels Jul 20, 2022
@domoscargin domoscargin self-assigned this Aug 15, 2022
@domoscargin
Copy link
Contributor Author

Since the watch task relies on the gulp tasks styles, sassdoc and scripts, I'm going to adjust its positioning in this work.

@domoscargin domoscargin removed their assignment Aug 15, 2022
@kellylee-gds kellylee-gds added this to the Remove or improve Gulp milestone Jan 31, 2023
@kellylee-gds kellylee-gds removed this from the Remove or improve Gulp milestone Feb 2, 2023
@colinrotherham colinrotherham moved this from Backlog 🗄 to Needs review 🔍 in GOV.UK Design System cycle board Mar 28, 2023
@colinrotherham colinrotherham linked a pull request Mar 28, 2023 that will close this issue
@colinrotherham colinrotherham self-assigned this Mar 30, 2023
@colinrotherham
Copy link
Contributor

This issue was picked up in:

It's ready for review but we'll need to decide:

  1. Do we keep gulp.watch() and close this?
  2. Do we replace gulp.watch() but keep gulp.parallel() for logging (based on #3384 feedback)
  3. Do we replace gulp.watch() with a better tool (Browsersync?) versus a like-for-like replacement

@domoscargin
Copy link
Contributor Author

I'm inclined to do 1 or 3.

gulp.watch() is a pretty core part of Gulp's functionality so I think 2 (deftly shown in #3428) feels like a step too far.

I vote we go with 1 for now and open an issue to investigate an alternative which we can pick up if we find the solution holds us back from anything.

@colinrotherham
Copy link
Contributor

Yeah, same. Now that we've decided to keeping logging via the Gulp CLI my vote goes on 1) too

Mainly because there's too much overhead trying to replicate glob-watcher used by gulp.watch()

Thanks @domoscargin

@domoscargin domoscargin moved this from Needs review 🔍 to Done 🏁 in GOV.UK Design System cycle board Apr 11, 2023
@colinrotherham colinrotherham removed their assignment Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕔 hours A well understood issue which we expect to take less than a day to resolve. tooling
Projects
Development

Successfully merging a pull request may close this issue.

3 participants