Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old PR template #324

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Remove old PR template #324

merged 1 commit into from
Jun 27, 2024

Conversation

brucebolt
Copy link
Member

@brucebolt brucebolt commented Jun 27, 2024

This repo has two PR templates defined, so we get an amalgamation of both when raising a PR.

Screenshot 2024-06-27 at 13 02 56

Removing the old one, as we don't appear to be using it or formatting PRs in that way anymore.

Copy link
Member

@yndajas yndajas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that my emoji made it into the PR description screenshot 😅

Copy link
Member

@yndajas yndajas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I think "can" is meant to be "get" in the commit message?

This repo has two PR templates defined, so we get an amalgamation of
both when raising a PR.

Removing the old one, as we don't appear to be using it or formatting
PRs in that way anymore.
@brucebolt brucebolt force-pushed the remove-empty-pr-template branch from 4eb55ec to 50bdff7 Compare June 27, 2024 12:09
@brucebolt
Copy link
Member Author

Oh, I think "can" is meant to be "get" in the commit message?

Yeah, I've just fixed that.

@brucebolt brucebolt enabled auto-merge June 27, 2024 12:10
@brucebolt brucebolt merged commit 57fca25 into main Jun 27, 2024
9 checks passed
@brucebolt brucebolt deleted the remove-empty-pr-template branch June 27, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants