Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: optimize drawer usage, fix known issues #530

Merged
merged 6 commits into from
Dec 7, 2023
Merged

refactor: optimize drawer usage, fix known issues #530

merged 6 commits into from
Dec 7, 2023

Conversation

igauch
Copy link
Contributor

@igauch igauch commented Dec 4, 2023 •
edited by JounQin
Loading

close #247
close #529

@igauch igauch requested a review from fengtianze December 4, 2023 02:21
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 4, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: fd1bd2d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@alauda/ui Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@igauch igauch force-pushed the feat/drawer branch 2 times, most recently from 48f7652 to 1645970 Compare December 5, 2023 08:46
@JounQin JounQin changed the title chore: optimize drawer refactor: optimize drawer usage, fix known issues Dec 5, 2023
JounQin
JounQin reviewed Dec 6, 2023
View reviewed changes
JounQin
JounQin reviewed Dec 6, 2023
View reviewed changes
JounQin
JounQin reviewed Dec 6, 2023
View reviewed changes
JounQin
JounQin reviewed Dec 6, 2023
View reviewed changes
JounQin
JounQin reviewed Dec 6, 2023
View reviewed changes
JounQin
JounQin approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@JounQin JounQin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

辛苦大哥

@JounQin JounQin merged commit 9092f15 into master Dec 7, 2023
@JounQin JounQin deleted the feat/drawer branch December 7, 2023 08:28
@alaudabot alaudabot mentioned this pull request Dec 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fengtianze fengtianze fengtianze left review comments

@JounQin JounQin JounQin approved these changes

Assignees

@fengtianze fengtianze

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

优化 drawer [drawer] close 事件设计有缺陷，重复触发
3 participants
@igauch @JounQin @fengtianze