Rm flaky test #9628
Merged
Rm flaky test #9628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmoriceau
deleted the
bmoric/remove-acceptance-test-based-on-new-scheduler
branch
benmoriceau
added a commit
that referenced
this pull request
Jan 21, 2022
This reverts commit 16133cf.
pmossman
added a commit
that referenced
this pull request
Mar 4, 2022
* Revert "Rm flaky test (#9628)" This reverts commit 16133cf. * Restore the acceptance test running with the new scheduler * Add timeout * Isolate the new acceptance test * Update github action name * Attemptp to fix checkpointing * Check the state retrieval instead of the existance of the workflow * fix build * Add concurrent list for test * Do not wait for the workflow to be potentially destroy * Silencely ignore the cancel exception * Format * Trigger build * format * Remove unrelated changes * Update acceptance * Try to fix race condition * Try to slow down the connection * Disable test * Move the sleep * Rm useless sleep * Fix missing return * add repeated * try using infinite feed source for cancellation test * set limits on infinite feed source * misunderstood waitForJob, now correctly waiting for job to be in RUNNING * clean up PR, DRY create definition methods, clearer method name for waiting on job * fix acceptance tests action name * fix imports * more cleanup * revert temporalClient do-while change * fix workflow step names Co-authored-by: Benoit Moriceau <benoit@airbyte.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The test will be re-enable with #9627