Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix Slack schema and retry function #9575

Merged
merged 4 commits into from
Jan 26, 2022
Merged

🐛 Fix Slack schema and retry function #9575

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
40ea41f
remove datetime from bot-profile channel_msgs
marcosmarxm Jan 17, 2022
13dc6f8
correct retry-after
marcosmarxm Jan 18, 2022
7f03f44
return retry-after
marcosmarxm Jan 18, 2022
e8eb7db
bump connector version
marcosmarxm Jan 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions airbyte-integrations/connectors/source-slack/source_slack/schemas/channel_messages.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,7 @@
"type": ["null", "string"]
},
"updated": {
"type": ["null", "string"],
"format": "date-time"
"type": ["null", "string"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does normalization perform migration to the destination table when a type changes?

Copy link
Member Author

@marcosmarxm marcosmarxm Jan 26, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, you need to update the schema to get the latest data type. Normalization runs everytime the new dbt project, so if you update to latest data type will generate the right normalization

}
},
"type": ["null", "object"]
Expand Down