🐛 Fix Slack schema and retry function #9575

marcosmarxm · 2022-01-18T13:45:08Z

What

Correct Slack tests

How

Describe the solution

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here
After the new connector version is published, connector version bumped in the seed directory as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed.

marcosmarxm · 2022-01-18T13:45:19Z

/test connector=connectors/source-slack

🕑 connectors/source-slack https://github.com/airbytehq/airbyte/actions/runs/1713010886
❌ connectors/source-slack https://github.com/airbytehq/airbyte/actions/runs/1713010886
🐛 https://gradle.com/s/h3saiotazfeny
Python short test summary info:

=========================== short test summary info ============================
FAILED test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/tests/test_incremental.py:21: `future_state_path` not specified, skipping
============= 1 failed, 16 passed, 1 skipped in 2917.98s (0:48:37) =============

marcosmarxm · 2022-01-18T17:17:56Z

/test connector=connectors/source-slack

🕑 connectors/source-slack https://github.com/airbytehq/airbyte/actions/runs/1713984160
✅ connectors/source-slack https://github.com/airbytehq/airbyte/actions/runs/1713984160
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      6    92%
	 source_acceptance_test/conftest.py                     109    109     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              242     96    60%
	 source_acceptance_test/tests/test_full_refresh.py       38      0   100%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  54     17    69%
	 source_acceptance_test/utils/compare.py                 62     23    63%
	 source_acceptance_test/utils/connector_runner.py       110     48    56%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  979    404    59%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                       Stmts   Miss  Cover
	 ----------------------------------------------
	 source_slack/__init__.py       2      2     0%
	 source_slack/source.py       189    189     0%
	 ----------------------------------------------
	 ----------------------------------------------/actions-runner/_work/airbyte/airbyte/airbyte-integrations/connectors/source-slack/.venv/lib/python3.8/site-packages/coverage/control.py:768: CoverageWarning: No data was collected. (no-data-collected)
	   self._warn("No data was collected.", slug="no-data-collected")
	 TOTAL                        191    191     0%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                       Stmts   Miss  Cover
	 ----------------------------------------------
	 source_slack/__init__.py       2      2     0%
	 source_slack/source.py       189    189     0%
	 ----------------------------------------------
	 TOTAL                        191    191     0%

Python short test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/tests/test_incremental.py:21: `future_state_path` not specified, skipping
================== 17 passed, 1 skipped in 4289.49s (1:11:29) ==================

marcosmarxm · 2022-01-26T20:15:49Z

/publish connector=connectors/source-slack

🕑 connectors/source-slack https://github.com/airbytehq/airbyte/actions/runs/1752832018
✅ connectors/source-slack https://github.com/airbytehq/airbyte/actions/runs/1752832018

alafanechere · 2022-01-26T20:26:57Z

airbyte-integrations/connectors/source-slack/source_slack/schemas/channel_messages.json

@@ -38,8 +38,7 @@
          "type": ["null", "string"]
        },
        "updated": {
-          "type": ["null", "string"],
-          "format": "date-time"
+          "type": ["null", "string"]


Does normalization perform migration to the destination table when a type changes?

No, you need to update the schema to get the latest data type. Normalization runs everytime the new dbt project, so if you update to latest data type will generate the right normalization

marcosmarxm added 2 commits January 17, 2022 15:23

remove datetime from bot-profile channel_msgs

40ea41f

correct retry-after

13dc6f8

github-actions bot added the area/connectors Connector related issues label Jan 18, 2022

marcosmarxm requested review from harshithmullapudi and alafanechere January 18, 2022 13:45

octavia-squidington-iii temporarily deployed to more-secrets January 18, 2022 13:47 Inactive

return retry-after

7f03f44

marcosmarxm temporarily deployed to more-secrets January 18, 2022 13:50 Inactive

octavia-squidington-iii temporarily deployed to more-secrets January 18, 2022 17:20 Inactive

alafanechere approved these changes Jan 18, 2022

View reviewed changes

bump connector version

e8eb7db

github-actions bot added the area/documentation Improvements or additions to documentation label Jan 26, 2022

marcosmarxm temporarily deployed to more-secrets January 26, 2022 20:16 Inactive

octavia-squidington-iii temporarily deployed to more-secrets January 26, 2022 20:18 Inactive

alafanechere reviewed Jan 26, 2022

View reviewed changes

marcosmarxm merged commit 40194c6 into master Jan 26, 2022

marcosmarxm deleted the marcos/fix-slack-schema branch January 26, 2022 21:55

This was referenced Jan 28, 2022

Bump Airbyte version from 0.35.11-alpha to 0.35.12-alpha #9856

Closed

Bump Airbyte version from 0.35.11-alpha to 0.35.12-alpha #9857

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🐛 Fix Slack schema and retry function #9575

🐛 Fix Slack schema and retry function #9575

marcosmarxm commented Jan 18, 2022 •

edited

Loading

marcosmarxm commented Jan 18, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Jan 18, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Jan 26, 2022 •

edited by github-actions bot

Loading

alafanechere Jan 26, 2022

marcosmarxm Jan 26, 2022 •

edited

Loading

🐛 Fix Slack schema and retry function #9575

🐛 Fix Slack schema and retry function #9575

Conversation

marcosmarxm commented Jan 18, 2022 • edited Loading

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

marcosmarxm commented Jan 18, 2022 • edited by github-actions bot Loading

marcosmarxm commented Jan 18, 2022 • edited by github-actions bot Loading

marcosmarxm commented Jan 26, 2022 • edited by github-actions bot Loading

alafanechere Jan 26, 2022

Choose a reason for hiding this comment

marcosmarxm Jan 26, 2022 • edited Loading

Choose a reason for hiding this comment

marcosmarxm commented Jan 18, 2022 •

edited

Loading

marcosmarxm commented Jan 18, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Jan 18, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Jan 26, 2022 •

edited by github-actions bot

Loading

marcosmarxm Jan 26, 2022 •

edited

Loading