Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add template for updating source connector type #9430

Merged
merged 1 commit into from
Jan 15, 2022
Merged

Add template for updating source connector type #9430

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions .github/ISSUE_TEMPLATE/source-connector-type.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
---

name: Source Connector Type
about: Add a new type or update an existing type in source connector
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is for adding support for new types in the Airbyte type system? what's an example for how it would be used?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what we talked about on Monday. It is not just adding new types, but also for updating an existing type. An example is to change the timestamp precision from second to millisecond.

title: '[EPIC] Add new type / update <type-name> in source connector <connector-name>'
labels: area/connectors, needs-triage
assignees: ''

---

## Summary
(Choose one of the two below.)
- [ ] Support new type <type-name>
- [ ] Update existing type <type-name>

## TODOs
(Complete the TODOs based on the instruction, and convert each bullet point with the `[Issue]` tag into an issue.)
- [ ] [Issue] Add a new destination acceptance test (DAT) test case for this type.
- List every destination below, either update the destination to suppor this type, or override its DAT to bypass the new test case.
- [ ] Example: [Issue] support <type-name> in destination bigquery
- [ ] [Issue] Make sure every destination can pass the new DAT test case.
- Even if a destination does not need to support this type, its DAT should not break.
- List every source that should support this type below.
- [ ] Example: [Issue] support <type-name> in source github

## Desired Timeline