Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add template for updating source connector type #9430

Merged
merged 1 commit into from
Jan 15, 2022

Conversation

tuliren
Copy link
Contributor

@tuliren tuliren commented Jan 12, 2022

What

  • Add new type or update an existing type in the source connector can be complicated because it can affect every destination.
  • @alexandr-shegeda, @oustynova, this is the proposed new procedure for any type-related work in the source connector. For each type-related project, we should create an EPIC according to the template.

How

  • Add test case first in the destination acceptance test (DAT).
  • Make sure that all the destinations can read the new type. Or at least they will not break.
  • Verify that all destination can pass the new DAT test case.
  • Update source connectors to support the new type as the last step.

@tuliren
Copy link
Contributor Author

tuliren commented Jan 12, 2022

I have updated this issue to adopt this template as an example: #8904

---

name: Source Connector Type
about: Add a new type or update an existing type in source connector
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is for adding support for new types in the Airbyte type system? what's an example for how it would be used?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what we talked about on Monday. It is not just adding new types, but also for updating an existing type. An example is to change the timestamp precision from second to millisecond.

@tuliren tuliren merged commit 103c224 into master Jan 15, 2022
@tuliren tuliren deleted the liren/source-connector-type-issue-template branch January 15, 2022 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants