Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fields in source-connectors specifications: google-analytics-v4 #9165

Merged
merged 10 commits into from
Jan 19, 2022
Merged

Update fields in source-connectors specifications: google-analytics-v4 #9165

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a2d9910
Upd
ycherniaiev Dec 28, 2021
64febbb
Update google-analytics-v4.md
ycherniaiev Dec 28, 2021
32b9481
Update spec.json
ycherniaiev Jan 4, 2022
b784949
Merge branch 'master' into ycherniaiev/isuue-8927-update-title-descri…
grubberr Jan 18, 2022
fb1bd68
fix version
grubberr Jan 18, 2022
42f0b92
Merge branch 'master' into ycherniaiev/isuue-8927-update-title-descri…
grubberr Jan 19, 2022
ddfd351
eff3616a-f9c3-11eb-9a03-0242ac130003.json updated
grubberr Jan 19, 2022
7ac5bd6
Merge branch 'master' into ycherniaiev/isuue-8927-update-title-descri…
grubberr Jan 19, 2022
81d8135
fixes
grubberr Jan 19, 2022
875db0c
source_specs.yaml updated
grubberr Jan 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-config/init/src/main/resources/seed/source_definitions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@
- name: Google Analytics
sourceDefinitionId: eff3616a-f9c3-11eb-9a03-0242ac130003
dockerRepository: airbyte/source-google-analytics-v4
dockerImageTag: 0.1.14
dockerImageTag: 0.1.15
documentationUrl: https://docs.airbyte.io/integrations/sources/google-analytics-v4
icon: google-analytics.svg
sourceType: api
Expand Down
11 changes: 6 additions & 5 deletions ...e-integrations/connectors/source-google-analytics-v4/source_google_analytics_v4/spec.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"order": 1,
"type": "string",
"title": "Start Date",
"description": "A date in the format YYYY-MM-DD.",
"description": "UTC date and time in the format 2017-01-25T00:00:00Z. Any data before this date will not be replicated.",
"examples": ["2020-06-01"]
},
"custom_reports": {
Expand Down Expand Up @@ -46,25 +46,25 @@
"client_id": {
"title": "Client ID",
"type": "string",
"description": "The Client ID of your developer application",
"description": "The Client ID of your Google Analytics developer application.",
"airbyte_secret": true
},
"client_secret": {
"title": "Client Secret",
"type": "string",
"description": "The client secret of your developer application",
"description": "The Client Secret of your Google Anayltics developer application.",
"airbyte_secret": true
},
"refresh_token": {
"title": "Refresh Token",
"type": "string",
"description": "A refresh token generated using the above client ID and secret",
"description": "The token for obtaining new access token ",
Copy link
Contributor

@grubberr grubberr Dec 31, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need "dot" here after word "token" ?

"airbyte_secret": true
},
"access_token": {
"title": "Access Token",
"type": "string",
"description": "A access token generated using the above client ID, secret and refresh_token",
"description": "Access Token for making authenticated requests.",
"airbyte_secret": true
}
}
Expand All @@ -82,6 +82,7 @@
"order": 0
},
"credentials_json": {
"title": "JSON credentials",
"type": "string",
"description": "The JSON key of the service account to use for authorization",
"examples": [
Expand Down
1 change: 1 addition & 0 deletions docs/integrations/sources/google-analytics-v4.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,7 @@ The Google Analytics connector should not run into Google Analytics API limitati

| Version | Date | Pull Request | Subject |
| :--- | :--- | :--- | :--- |
| 0.1.15 | 2021-12-28 | [9165](https://github.com/airbytehq/airbyte/pull/9165) | Update titles and descriptions |
| 0.1.14 | 2021-12-09 | [8656](https://github.com/airbytehq/airbyte/pull/8656) | Fix date-format in schemas |
| 0.1.13 | 2021-12-09 | [8676](https://github.com/airbytehq/airbyte/pull/8676) | Fix `window_in_days` validation issue |
| 0.1.12 | 2021-12-03 | [8175](https://github.com/airbytehq/airbyte/pull/8175) | Fix validation of unknown metric(s) or dimension(s) error |
Expand Down