Update fields in source-connectors specifications: google-analytics-v4 #9165

ycherniaiev · 2021-12-28T19:21:44Z

What

Add title and description properties to each field in source-connectors specifications:
source-google-analytics-v4

How

Describe the solution

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here
After the new connector version is published, connector version bumped in the seed directory as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

This change is

ycherniaiev · 2021-12-29T10:44:46Z

/test connector=connectors/source-google-analytics-v4

🕑 connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/1633715628
✅ connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/1633715628
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      6    92%
	 source_acceptance_test/conftest.py                     109    109     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              242     96    60%
	 source_acceptance_test/tests/test_full_refresh.py       38      0   100%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  54     17    69%
	 source_acceptance_test/utils/compare.py                 62     23    63%
	 source_acceptance_test/utils/connector_runner.py       110     48    56%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  979    404    59%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                     Stmts   Miss  Cover
	 ------------------------------------------------------------
	 source_google_analytics_v4/__init__.py       2      0   100%
	 source_google_analytics_v4/source.py       263     76    71%
	 ------------------------------------------------------------
	 TOTAL                                      265     76    71%

Python short test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/tests/test_incremental.py:21: `future_state_path` not specified, skipping
======================== 16 passed, 1 skipped in 58.82s ========================

ycherniaiev · 2021-12-31T10:29:14Z

/test connector=connectors/destination-google-analytics-v4

🕑 connectors/destination-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/1640472263
❌ connectors/destination-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/1640472263
🐛

ycherniaiev · 2021-12-31T12:39:13Z

/test connector=connectors/source-google-analytics-v4

🕑 connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/1640752442
✅ connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/1640752442
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      6    92%
	 source_acceptance_test/conftest.py                     109    109     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              242     96    60%
	 source_acceptance_test/tests/test_full_refresh.py       38      0   100%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  54     17    69%
	 source_acceptance_test/utils/compare.py                 62     23    63%
	 source_acceptance_test/utils/connector_runner.py       110     48    56%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  979    404    59%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                     Stmts   Miss  Cover
	 ------------------------------------------------------------
	 source_google_analytics_v4/__init__.py       2      0   100%
	 source_google_analytics_v4/source.py       263     76    71%
	 ------------------------------------------------------------
	 TOTAL                                      265     76    71%

Python short test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/tests/test_incremental.py:21: `future_state_path` not specified, skipping
================== 16 passed, 1 skipped in 587.33s (0:09:47) ===================

grubberr · 2021-12-31T13:15:33Z

airbyte-integrations/connectors/source-google-analytics-v4/source_google_analytics_v4/spec.json

                "airbyte_secret": true
              },
              "refresh_token": {
                "title": "Refresh Token",
                "type": "string",
-                "description": "A refresh token generated using the above client ID and secret",
+                "description": "The token for obtaining new access token ",


do we need "dot" here after word "token" ?

…ption

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr · 2022-01-18T13:57:53Z

/test connector=connectors/destination-google-analytics-v4

🕑 connectors/destination-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/1713064683
❌ connectors/destination-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/1713064683
🐛

grubberr · 2022-01-19T10:45:20Z

/test connector=connectors/source-google-analytics-v4

🕑 connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/1717544923
✅ connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/1717544923
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      6    92%
	 source_acceptance_test/conftest.py                     109    109     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              242     96    60%
	 source_acceptance_test/tests/test_full_refresh.py       38      0   100%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  54     17    69%
	 source_acceptance_test/utils/compare.py                 62     23    63%
	 source_acceptance_test/utils/connector_runner.py       110     48    56%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  979    404    59%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                     Stmts   Miss  Cover
	 ------------------------------------------------------------
	 source_google_analytics_v4/__init__.py       2      0   100%
	 source_google_analytics_v4/source.py       263     76    71%
	 ------------------------------------------------------------
	 TOTAL                                      265     76    71%

Python short test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/tests/test_incremental.py:21: `future_state_path` not specified, skipping
=================== 16 passed, 1 skipped in 85.52s (0:01:25) ===================

…ption

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

…ption

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr · 2022-01-19T11:40:56Z

/test connector=connectors/source-google-analytics-v4

🕑 connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/1717771709
✅ connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/1717771709
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      6    92%
	 source_acceptance_test/conftest.py                     109    109     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              242     96    60%
	 source_acceptance_test/tests/test_full_refresh.py       38      0   100%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  54     17    69%
	 source_acceptance_test/utils/compare.py                 62     23    63%
	 source_acceptance_test/utils/connector_runner.py       110     48    56%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  979    404    59%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                     Stmts   Miss  Cover
	 ------------------------------------------------------------
	 source_google_analytics_v4/__init__.py       2      0   100%
	 source_google_analytics_v4/source.py       263     76    71%
	 ------------------------------------------------------------
	 TOTAL                                      265     76    71%

Python short test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/tests/test_incremental.py:21: `future_state_path` not specified, skipping
=================== 16 passed, 1 skipped in 63.75s (0:01:03) ===================

grubberr · 2022-01-19T11:52:58Z

/publish connector=connectors/source-google-analytics-v4

🕑 connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/1717816432
✅ connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/1717816432

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

Upd

a2d9910

ycherniaiev added area/documentation Improvements or additions to documentation area/connectors Connector related issues labels Dec 28, 2021

ycherniaiev self-assigned this Dec 28, 2021

ycherniaiev temporarily deployed to more-secrets December 28, 2021 19:21 Inactive

github-actions bot removed the area/documentation Improvements or additions to documentation label Dec 28, 2021

ycherniaiev linked an issue Dec 28, 2021 that may be closed by this pull request

Update fields in source-connectors specifications: google-analytics-v4 #8927

Closed

ycherniaiev added the area/documentation Improvements or additions to documentation label Dec 28, 2021

ycherniaiev requested a review from grubberr December 28, 2021 19:23

ycherniaiev removed a link to an issue Dec 28, 2021

Update fields in source-connectors specifications: google-analytics-v4 #8927

Closed

ycherniaiev linked an issue Dec 28, 2021 that may be closed by this pull request

Update fields in source-connectors specifications: google-analytics-v4 #8927

Closed

ycherniaiev changed the title ~~Update fields in source-connectors specifications: google-ads~~ Update fields in source-connectors specifications: google-analyics Dec 28, 2021

ycherniaiev changed the title ~~Update fields in source-connectors specifications: google-analyics~~ Update fields in source-connectors specifications: google-analyics-v4 Dec 28, 2021

Update google-analytics-v4.md

64febbb

ycherniaiev temporarily deployed to more-secrets December 28, 2021 19:33 Inactive

ycherniaiev changed the title ~~Update fields in source-connectors specifications: google-analyics-v4~~ Update fields in source-connectors specifications: google-analytics-v4 Dec 29, 2021

jrhizor temporarily deployed to more-secrets December 29, 2021 10:47 Inactive

jrhizor temporarily deployed to more-secrets December 31, 2021 10:31 Inactive

jrhizor temporarily deployed to more-secrets December 31, 2021 12:41 Inactive

grubberr suggested changes Dec 31, 2021

View reviewed changes

Update spec.json

32b9481

ycherniaiev temporarily deployed to more-secrets January 4, 2022 09:14 Inactive

igrankova assigned grubberr Jan 5, 2022

grubberr added 2 commits January 18, 2022 15:56

Merge branch 'master' into ycherniaiev/isuue-8927-update-title-descri…

b784949

…ption

fix version

fb1bd68

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr temporarily deployed to more-secrets January 18, 2022 13:59 Inactive

octavia-squidington-iii temporarily deployed to more-secrets January 18, 2022 14:00 Inactive

octavia-squidington-iii temporarily deployed to more-secrets January 19, 2022 10:47 Inactive

grubberr added 3 commits January 19, 2022 13:11

Merge branch 'master' into ycherniaiev/isuue-8927-update-title-descri…

42f0b92

…ption

eff3616a-f9c3-11eb-9a03-0242ac130003.json updated

ddfd351

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

Merge branch 'master' into ycherniaiev/isuue-8927-update-title-descri…

7ac5bd6

…ption

grubberr temporarily deployed to more-secrets January 19, 2022 11:20 Inactive

fixes

81d8135

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr temporarily deployed to more-secrets January 19, 2022 11:42 Inactive

octavia-squidington-iii temporarily deployed to more-secrets January 19, 2022 11:43 Inactive

octavia-squidington-iii temporarily deployed to more-secrets January 19, 2022 11:55 Inactive

source_specs.yaml updated

875db0c

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr self-requested a review January 19, 2022 12:10

grubberr approved these changes Jan 19, 2022

View reviewed changes

grubberr merged commit df4b4d6 into master Jan 19, 2022

grubberr deleted the ycherniaiev/isuue-8927-update-title-description branch January 19, 2022 12:11

grubberr temporarily deployed to more-secrets January 19, 2022 12:11 Inactive

octavia-squidington-iii mentioned this pull request Jan 20, 2022

Bump Airbyte version from 0.35.5-alpha to 0.35.6-alpha #9630

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update fields in source-connectors specifications: google-analytics-v4 #9165

Update fields in source-connectors specifications: google-analytics-v4 #9165

ycherniaiev commented Dec 28, 2021 •

edited by keu

Loading

ycherniaiev commented Dec 29, 2021 •

edited by github-actions bot

Loading

ycherniaiev commented Dec 31, 2021 •

edited by github-actions bot

Loading

ycherniaiev commented Dec 31, 2021 •

edited by github-actions bot

Loading

grubberr Dec 31, 2021 •

edited

Loading

grubberr commented Jan 18, 2022 •

edited by github-actions bot

Loading

grubberr commented Jan 19, 2022 •

edited by github-actions bot

Loading

grubberr commented Jan 19, 2022 •

edited by github-actions bot

Loading

grubberr commented Jan 19, 2022 •

edited by github-actions bot

Loading

Update fields in source-connectors specifications: google-analytics-v4 #9165

Update fields in source-connectors specifications: google-analytics-v4 #9165

Conversation

ycherniaiev commented Dec 28, 2021 • edited by keu Loading

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

ycherniaiev commented Dec 29, 2021 • edited by github-actions bot Loading

ycherniaiev commented Dec 31, 2021 • edited by github-actions bot Loading

ycherniaiev commented Dec 31, 2021 • edited by github-actions bot Loading

grubberr Dec 31, 2021 • edited Loading

Choose a reason for hiding this comment

grubberr commented Jan 18, 2022 • edited by github-actions bot Loading

grubberr commented Jan 19, 2022 • edited by github-actions bot Loading

grubberr commented Jan 19, 2022 • edited by github-actions bot Loading

grubberr commented Jan 19, 2022 • edited by github-actions bot Loading

ycherniaiev commented Dec 28, 2021 •

edited by keu

Loading

ycherniaiev commented Dec 29, 2021 •

edited by github-actions bot

Loading

ycherniaiev commented Dec 31, 2021 •

edited by github-actions bot

Loading

ycherniaiev commented Dec 31, 2021 •

edited by github-actions bot

Loading

grubberr Dec 31, 2021 •

edited

Loading

grubberr commented Jan 18, 2022 •

edited by github-actions bot

Loading

grubberr commented Jan 19, 2022 •

edited by github-actions bot

Loading

grubberr commented Jan 19, 2022 •

edited by github-actions bot

Loading

grubberr commented Jan 19, 2022 •

edited by github-actions bot

Loading