-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Source Marketo: Fix timestamp value format issue #8298
🐛 Source Marketo: Fix timestamp value format issue #8298
Conversation
/test connector=connectors/source-marketo
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add as integration test for checking of correct values
/test connector=connectors/source-marketo
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Please publish these changes
/publish connector=connectors/source-marketo
|
* Fix timestamp value format issue * Fix spec to UI handbook * Added expected records to integration tests * Bumped version in seed and spec yaml
What
Connector receives 'bad' formated values for
createdAt
andupdatedAt
fields (e.g.2015-05-21T22:45:13Z+0000
). According to this destination normalization could not parse value asdate-time
format (e.g. Snowflake).How
During parsing, records delete
+00:00
part from the end ofcreatedAt
andupdatedAt
(e.g.2015-05-21T22:45:13Z+0000
).Changed
spec.json
file according to UX Handbook and this comment.Recommended reading order
x.java
y.python
Pre-merge Checklist
Expand the relevant checklist and delete the others.
Updating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described here