Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Marketo: Fix timestamp value format issue #8298

Merged

Conversation

lazebnyi
Copy link
Collaborator

@lazebnyi lazebnyi commented Nov 29, 2021

What

Connector receives 'bad' formated values for createdAt and updatedAt fields (e.g. 2015-05-21T22:45:13Z+0000). According to this destination normalization could not parse value as date-time format (e.g. Snowflake).

How

During parsing, records delete +00:00 part from the end of createdAt and updatedAt (e.g. 2015-05-21T22:45:13Z+0000).

Changed spec.json file according to UX Handbook and this comment.

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Nov 29, 2021
@lazebnyi lazebnyi requested review from antixar and grubberr November 29, 2021 12:25
@lazebnyi lazebnyi temporarily deployed to more-secrets November 29, 2021 12:26 Inactive
@lazebnyi lazebnyi linked an issue Nov 29, 2021 that may be closed by this pull request
@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Nov 29, 2021

/test connector=connectors/source-marketo

🕑 connectors/source-marketo https://github.com/airbytehq/airbyte/actions/runs/1515967866
❌ connectors/source-marketo https://github.com/airbytehq/airbyte/actions/runs/1515967866
🐛 https://gradle.com/s/wa7d2t6poywfw
🕑 connectors/source-marketo https://github.com/airbytehq/airbyte/actions/runs/1515967866
✅ connectors/source-marketo https://github.com/airbytehq/airbyte/actions/runs/1515967866
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        75      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              200     94    53%
	 source_acceptance_test/tests/test_full_refresh.py       38     27    29%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     24    41%
	 source_acceptance_test/utils/compare.py                 62     25    60%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  896    440    51%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                         Stmts   Miss  Cover
	 ------------------------------------------------
	 source_marketo/__init__.py       2      0   100%
	 source_marketo/source.py       237    151    36%
	 source_marketo/utils.py         31      8    74%
	 ------------------------------------------------
	 TOTAL                          270    159    41%

@jrhizor jrhizor temporarily deployed to more-secrets November 29, 2021 12:44 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets November 29, 2021 16:51 Inactive
Copy link
Contributor

@antixar antixar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add as integration test for checking of correct values

@lazebnyi lazebnyi requested a review from antixar December 3, 2021 11:05
@lazebnyi lazebnyi temporarily deployed to more-secrets December 3, 2021 11:07 Inactive
@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Dec 3, 2021

/test connector=connectors/source-marketo

🕑 connectors/source-marketo https://github.com/airbytehq/airbyte/actions/runs/1534950725
✅ connectors/source-marketo https://github.com/airbytehq/airbyte/actions/runs/1534950725
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        75      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              200     94    53%
	 source_acceptance_test/tests/test_full_refresh.py       38     27    29%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     24    41%
	 source_acceptance_test/utils/compare.py                 62     25    60%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  896    440    51%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                         Stmts   Miss  Cover
	 ------------------------------------------------
	 source_marketo/__init__.py       2      0   100%
	 source_marketo/source.py       237    151    36%
	 source_marketo/utils.py         31      8    74%
	 ------------------------------------------------
	 TOTAL                          270    159    41%

@jrhizor jrhizor temporarily deployed to more-secrets December 3, 2021 11:13 Inactive
Copy link
Contributor

@antixar antixar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Please publish these changes

@lazebnyi lazebnyi marked this pull request as ready for review December 6, 2021 10:28
@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Dec 6, 2021

/publish connector=connectors/source-marketo

🕑 connectors/source-marketo https://github.com/airbytehq/airbyte/actions/runs/1544175957
❌ connectors/source-marketo https://github.com/airbytehq/airbyte/actions/runs/1544175957
🕑 connectors/source-marketo https://github.com/airbytehq/airbyte/actions/runs/1544175957
✅ connectors/source-marketo https://github.com/airbytehq/airbyte/actions/runs/1544175957

@lazebnyi lazebnyi temporarily deployed to more-secrets December 6, 2021 10:31 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 6, 2021 10:33 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 6, 2021 16:28 Inactive
@lazebnyi lazebnyi merged commit cb120fe into master Dec 6, 2021
@lazebnyi lazebnyi deleted the lazebnyi/8296-fix-marketo-timestamp-value-format-issue branch December 6, 2021 18:12
@lazebnyi lazebnyi temporarily deployed to more-secrets December 6, 2021 18:13 Inactive
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
* Fix timestamp value format issue

* Fix spec to UI handbook

* Added expected records to integration tests

* Bumped version in seed and spec yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Source Marketo: Fix timestamp value format issue
3 participants