🐛 Source Marketo: Fix timestamp value format issue (#8298)

* Fix timestamp value format issue

* Fix spec to UI handbook

* Added expected records to integration tests

* Bumped version in seed and spec yaml

Author: lazebnyi

airbyte-config/init/src/main/resources/config/STANDARD_SOURCE_DEFINITION/9e0556f4-69df-4522-a3fb-03264d36b348.json

@@ -2,7 +2,7 @@
   "sourceDefinitionId": "9e0556f4-69df-4522-a3fb-03264d36b348",
   "name": "Marketo",
   "dockerRepository": "airbyte/source-marketo",
-  "dockerImageTag": "0.1.0",
+  "dockerImageTag": "0.1.1",
   "documentationUrl": "https://docs.airbyte.io/integrations/sources/marketo",
   "icon": "marketo.svg"
 }

airbyte-config/init/src/main/resources/seed/source_definitions.yaml

@@ -372,7 +372,7 @@
 - name: Marketo
   sourceDefinitionId: 9e0556f4-69df-4522-a3fb-03264d36b348
   dockerRepository: airbyte/source-marketo
-  dockerImageTag: 0.1.0
+  dockerImageTag: 0.1.1
   documentationUrl: https://docs.airbyte.io/integrations/sources/marketo
   icon: marketo.svg
   sourceType: api

airbyte-config/init/src/main/resources/seed/source_specs.yaml

@@ -3473,7 +3473,7 @@
     supportsNormalization: false
     supportsDBT: false
     supported_destination_sync_modes: []
-- dockerImage: "airbyte/source-marketo:0.1.0"
+- dockerImage: "airbyte/source-marketo:0.1.1"
   spec:
     documentationUrl: "https://docs.airbyte.io/integrations/sources/marketo"
     connectionSpecification:

airbyte-integrations/connectors/source-marketo/Dockerfile

@@ -34,5 +34,5 @@ COPY source_marketo ./source_marketo
 ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
 ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]
 
-LABEL io.airbyte.version=0.1.0
+LABEL io.airbyte.version=0.1.1
 LABEL io.airbyte.name=airbyte/source-marketo

airbyte-integrations/connectors/source-marketo/acceptance-test-config.yml

@@ -16,6 +16,8 @@ tests:
       configured_catalog_path: "integration_tests/configured_catalog.json"
       empty_streams: []
       timeout_seconds: 3600
+      expect_records:
+        path: "integration_tests/expected_records.txt"
   incremental:
     - config_path: "secrets/config.json"
       configured_catalog_path: "integration_tests/configured_catalog.json"

airbyte-integrations/connectors/source-marketo/integration_tests/expected_records.txt

@@ -29,7 +29,7 @@ def __init__(self, config: Mapping[str, Any], stream_name: str = None, param: Ma
         super().__init__(authenticator=config["authenticator"])
         self.config = config
         self.start_date = config["start_date"]
-        self.window_in_days = config["window_in_days"]
+        self.window_in_days = config.get("window_in_days", 30)
         self._url_base = config["domain_url"].rstrip("/") + "/"
         self.stream_name = stream_name
         self.param = param
@@ -435,7 +435,8 @@ def request_params(
 
     def parse_response(self, response: requests.Response, stream_state: Mapping[str, Any], **kwargs) -> Iterable[Mapping]:
         for record in super().parse_response(response, stream_state, **kwargs):
-            record["updatedAt"] = record["updatedAt"][:-5]  # delete +00:00 part from the end of updatedAt
+            # delete +00:00 part from the end of createdAt and updatedAt
+            record["updatedAt"], record["createdAt"] = record["updatedAt"][:-5], record["createdAt"][:-5]
             yield record
 
 

airbyte-integrations/connectors/source-marketo/source_marketo/source.py

@@ -5,35 +5,37 @@
     "title": "Source Marketo Spec",
     "type": "object",
     "required": ["domain_url", "client_id", "client_secret", "start_date"],
-    "additionalProperties": false,
+    "additionalProperties": true,
     "properties": {
       "domain_url": {
+        "title": "Domain URL",
         "type": "string",
+        "order": 3,
         "description": "Your Marketo Base URL. See <a href=\"https://docs.airbyte.io/integrations/sources/marketo\"> the docs </a> for info on how to obtain this.",
         "examples": ["https://000-AAA-000.mktorest.com"],
         "airbyte_secret": true
       },
       "client_id": {
+        "title": "Client ID",
         "type": "string",
+        "order": 0,
         "description": "Your Marketo client_id. See <a href=\"https://docs.airbyte.io/integrations/sources/marketo\"> the docs </a> for info on how to obtain this.",
         "airbyte_secret": true
       },
       "client_secret": {
+        "title": "Client Secret",
         "type": "string",
+        "order": 1,
         "description": "Your Marketo client secret. See <a href=\"https://docs.airbyte.io/integrations/sources/marketo\"> the docs </a> for info on how to obtain this.",
         "airbyte_secret": true
       },
       "start_date": {
+        "title": "Start Date",
         "type": "string",
+        "order": 2,
         "description": "Data generated in Marketo after this date will be replicated. This date must be specified in the format YYYY-MM-DDT00:00:00Z.",
         "examples": ["2020-09-25T00:00:00Z"],
         "pattern": "^[0-9]{4}-[0-9]{2}-[0-9]{2}T[0-9]{2}:[0-9]{2}:[0-9]{2}Z$"
-      },
-      "window_in_days": {
-        "type": "integer",
-        "description": "The amount of days for each data-chunk begining from start_date. (Min=1, as for a Day; Max=30, as for a Month).",
-        "examples": [1, 5, 10, 15, 30],
-        "default": 30
       }
     }
   }

airbyte-integrations/connectors/source-marketo/source_marketo/spec.json

@@ -91,5 +91,6 @@ We're almost there! Armed with your Endpoint & Identity URLs and your Client ID
 
 | Version | Date | Pull Request | Subject |
 | :--- | :--- | :--- | :--- |
+| `0.1.1` | 2021-11-29 | [0000](https://github.com/airbytehq/airbyte/pull/0000) | Fix timestamp value format issue |
 | `0.1.0` | 2021-09-06 | [5863](https://github.com/airbytehq/airbyte/pull/5863) | Release Marketo CDK Connector |