✨ Source Freshdesk : Migrate to Manifest-only #54687
Conversation
…pe/freshdesk/migrate-to-manifest-only
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
|
/format-fix
|
|
The changes are alright. Once the conflicts are resolved, we should regression test this carefully. @DanyloGL will take a few days off, once he's back, we should push this forward. |
…pe/freshdesk/migrate-to-manifest-only
…pe/freshdesk/migrate-to-manifest-only
|
/format-fix
|
|
I'll see if we have capacity to run a regression test on this while @DanyloGL is out. |
| base_requester: | ||
| # This requester is used to count call credits used for requests to Freshdesk | ||
| type: CustomRequester | ||
| class_name: source_declarative_manifest.components.FreshdeskRequester |
There was a problem hiding this comment.
this one can be replaced with simplerequester + api_budget definition; see airbytehq/airbyte-python-cdk#314 and #53225 as a reference
There was a problem hiding this comment.
Thank you for catching this @artem1205 <3
There was a problem hiding this comment.
one issue here - I'm trying to get requests_per_minute from config to specify <FixedWindowCallRatePolicy>.call_limit with "{{ config.get('requests_per_minute')}}" but build fails due to schema validation error.
The field expects an integer not an interpolated string
|
@topefolorunso this is a relatively low hanging fruit, let me know when you're ready here. |
…pe/freshdesk/migrate-to-manifest-only
…hub.com/airbytehq/airbyte into tope/freshdesk/migrate-to-manifest-only
|
/format-fix
|
|
Build step is failing — it's likely due to an older baseImage in the metadata. |
|
one issue here - I'm trying to get requests_per_minute from config to specify .call_limit with "{{ config.get('requests_per_minute')}}" but build step fails due to schema validation error. The field expects an integer not an interpolated string |
…pe/freshdesk/migrate-to-manifest-only
|
/format-fix
|
|
@topefolorunso do you think you can populate tickets in expected records? Do you have the creds to do it? |
|
Overall this already looks good and I'd love to start a progressive rollout of this, when @DanyloGL is back. |
@natikgadzhi No I don't. Can you share again in slack dm? |
…pe/freshdesk/migrate-to-manifest-only
|
/format-fix
|
No description provided.