Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(source-amazon-seller-partner): Add API Budget #53225

Merged
merged 19 commits into from
Feb 24, 2025

Conversation

artem1205
Copy link
Collaborator

What

fix OrderItems & Orders rate limiting

How

  • Add API Budget

Review guide

User Impact

Can this PR be safely reverted and rolled back?

  • YES πŸ’š
  • NO ❌

[skip ci]

Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
@artem1205 artem1205 self-assigned this Feb 7, 2025
Copy link

vercel bot commented Feb 7, 2025

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
airbyte-docs βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Feb 24, 2025 6:12pm

Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
api_budget:
type: HTTPAPIBudget
# Each policy here uses a MovingWindowCallRatePolicy with two rates:
# one for burst (per-second) and one for steady (per-minute).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the steady ones, is it expected? I'm fine with trying this anyway but we might still get rate limited on the steady case

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, will fix it afterwards. I copypasted comments from klaviyo, amazon has a different calculation

Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
Copy link

@Charlesnorris509 Charlesnorris509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be aware that when you move the project on poetry, the dependecies changes must be made on poetry.lock and tend to impact the application as a whole, identify the impacted endpoints before updating the dependencies there

Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
…artner-api-budget-fix' into artem1205/source-amazon-seller-partner-api-budget-fix
@tolik0
Copy link
Contributor

tolik0 commented Feb 24, 2025

/format-fix

Format-fix job started... Check job output.

βœ… Changes applied successfully. (4d44136)

@tolik0 tolik0 marked this pull request as ready for review February 24, 2025 16:21
@tolik0 tolik0 requested a review from maxi297 February 24, 2025 16:40
Copy link
Contributor

@maxi297 maxi297 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tolik0 tolik0 merged commit 9f1b7fe into master Feb 24, 2025
26 of 28 checks passed
@tolik0 tolik0 deleted the artem1205/source-amazon-seller-partner-api-budget-fix branch February 24, 2025 19:41
@y-yoshimura-cipher
Copy link

@maxi297
The documentation for this change has not been updated.
Please check and confirm.

image

btkcodedev pushed a commit that referenced this pull request Mar 4, 2025
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
Co-authored-by: Anatolii Yatsuk <tolikyatsuk@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants