-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(source-amazon-seller-partner): Add API Budget #53225
feat(source-amazon-seller-partner): Add API Budget #53225
Conversation
[skip ci] Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
api_budget: | ||
type: HTTPAPIBudget | ||
# Each policy here uses a MovingWindowCallRatePolicy with two rates: | ||
# one for burst (per-second) and one for steady (per-minute). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see the steady ones, is it expected? I'm fine with trying this anyway but we might still get rate limited on the steady case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, will fix it afterwards. I copypasted comments from klaviyo, amazon has a different calculation
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Be aware that when you move the project on poetry, the dependecies changes must be made on poetry.lock and tend to impact the application as a whole, identify the impacted endpoints before updating the dependencies there
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
β¦artner-api-budget-fix' into artem1205/source-amazon-seller-partner-api-budget-fix
/format-fix
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@maxi297 |
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com> Co-authored-by: Anatolii Yatsuk <tolikyatsuk@gmail.com>
What
fix OrderItems & Orders rate limiting
How
Review guide
User Impact
Can this PR be safely reverted and rolled back?