Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bugfix incorrectly failing check connection operations in Google Ads and Amazon AP API connectors #4288

Merged
merged 2 commits into from
Jun 24, 2021
Merged

🐛 Bugfix incorrectly failing check connection operations in Google Ads and Amazon AP API connectors #4288

merged 2 commits into from
Jun 24, 2021

Conversation

harshithmullapudi
Copy link
Contributor

…oogle-ads

What

Check connection is failing for both amazon-seller-partner and g…

Pre-merge Checklist

Expand the checklist which is relevant for this PR.

Connector checklist

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • Secrets are annotated with airbyte_secret in output spec
  • Unit & integration tests added as appropriate (and are passing)
    • Community members: please provide proof of this succeeding locally e.g: screenshot or copy-paste acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • /test connector=connectors/<name> command as documented here is passing.
    • Community members can skip this, Airbyters will run this for you.
  • Code reviews completed
  • Credentials added to Github CI if needed and not already present. instructions for injecting secrets into CI.
  • Documentation updated
    • README
    • CHANGELOG.md
    • Reference docs in the docs/integrations/ directory.
    • Build status added to build page
  • Build is successful
  • Connector version bumped like described here
  • New Connector version released on Dockerhub by running the /publish command described here
  • No major blockers
  • PR merged into master branch
  • Follow up tickets have been created
  • Associated tickets have been closed & stakeholders notified

Connector Generator checklist

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Jun 23, 2021
marcosmarxm
marcosmarxm requested changes Jun 23, 2021
View reviewed changes
docs/integrations/sources/amazon-seller-partner.md Outdated
@@ -58,3 +58,4 @@ Information about how to get credentials you may find [here](https://github.com/
| Version | Date | Pull Request | Subject |
| :------ | :-------- | :----- | :------ |
| `0.1.2` | 2021-06-15 | [#4108](https://github.com/airbytehq/airbyte/pull/4108) | `Fixed: Sync fails with timeout when create report is CANCELLED` |
| `0.1.3` | 2021-06-23 | [#4288](https://github.com/airbytehq/airbyte/pull/4288) | `Fixed: Create connection is failing` |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harshithmullapudi we keep the latest version on top

@marcosmarxm marcosmarxm requested a review from sherifnada June 23, 2021 16:13
sherifnada
sherifnada approved these changes Jun 23, 2021
View reviewed changes
docs/integrations/sources/amazon-seller-partner.md Outdated
@@ -58,3 +58,4 @@ Information about how to get credentials you may find [here](https://github.com/
| Version | Date | Pull Request | Subject |
| :------ | :-------- | :----- | :------ |
| `0.1.2` | 2021-06-15 | [#4108](https://github.com/airbytehq/airbyte/pull/4108) | `Fixed: Sync fails with timeout when create report is CANCELLED` |
| `0.1.3` | 2021-06-23 | [#4288](https://github.com/airbytehq/airbyte/pull/4288) | `Fixed: Create connection is failing` |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| `0.1.3` | 2021-06-23 | [#4288](https://github.com/airbytehq/airbyte/pull/4288) | `Fixed: Create connection is failing` |

docs/integrations/sources/amazon-seller-partner.md
@@ -58,3 +58,4 @@ Information about how to get credentials you may find [here](https://github.com/
| Version | Date | Pull Request | Subject |
| :------ | :-------- | :----- | :------ |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| :------ | :-------- | :----- | :------ |
| :------ | :-------- | :----- | :------ |
| `0.1.3` | 2021-06-23 | [#4288](https://github.com/airbytehq/airbyte/pull/4288) | `Bugfix failing connection check` |

docs/integrations/sources/google-ads.md Outdated

| Version | Date | Pull Request | Subject |
| :------ | :-------- | :----- | :------ |
| `0.1.3` | 2021-06-23 | [#4288](https://github.com/airbytehq/airbyte/pull/4288) | `Fixed: Create source is failing` |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| `0.1.3` | 2021-06-23 | [#4288](https://github.com/airbytehq/airbyte/pull/4288) | `Fixed: Create source is failing` |
| `0.1.3` | 2021-06-23 | [#4288](https://github.com/airbytehq/airbyte/pull/4288) | `Bugfix: Correctly declare required parameters ` |

@sherifnada sherifnada changed the title Fix: Check connection is failing for both amazon-seller-partner and g… 🐛 Bugfix incorrectly failing check connection operations in Google Ads and Amazon AP API connectors Jun 24, 2021
@sherifnada sherifnada merged commit f4ddf40 into airbytehq:master Jun 24, 2021
This was referenced Jun 24, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcosmarxm marcosmarxm marcosmarxm requested changes

@sherifnada sherifnada sherifnada approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/amazon-seller-partner connectors/sources-api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@harshithmullapudi @marcosmarxm @sherifnada @igrankova