Skip to content

Commit cb4d30d

Browse files
Fix: Check connection is failing for both amazon-seller-partner and google-ads
1 parent 39fe5fe commit cb4d30d

File tree

9 files changed

+15
-12
lines changed

9 files changed

+15
-12
lines changed

airbyte-config/init/src/main/resources/config/STANDARD_SOURCE_DEFINITION/253487c0-2246-43ba-a21f-5116b20a2c50.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,6 @@
22
"sourceDefinitionId": "253487c0-2246-43ba-a21f-5116b20a2c50",
33
"name": "Google Ads",
44
"dockerRepository": "airbyte/source-google-ads",
5-
"dockerImageTag": "0.1.0",
5+
"dockerImageTag": "0.1.1",
66
"documentationUrl": "https://hub.docker.com/r/airbyte/source-google-ads"
77
}

airbyte-config/init/src/main/resources/config/STANDARD_SOURCE_DEFINITION/e55879a8-0ef8-4557-abcf-ab34c53ec460.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,6 @@
22
"sourceDefinitionId": "e55879a8-0ef8-4557-abcf-ab34c53ec460",
33
"name": "Amazon Seller Partner",
44
"dockerRepository": "airbyte/source-amazon-seller-partner",
5-
"dockerImageTag": "0.1.2",
5+
"dockerImageTag": "0.1.3",
66
"documentationUrl": "https://hub.docker.com/r/airbyte/source-amazon-seller-partner"
77
}

airbyte-config/init/src/main/resources/seed/source_definitions.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
- sourceDefinitionId: e55879a8-0ef8-4557-abcf-ab34c53ec460
22
name: Amazon Seller Partner
33
dockerRepository: airbyte/source-amazon-seller-partner
4-
dockerImageTag: 0.1.2
4+
dockerImageTag: 0.1.3
55
documentationUrl: https://hub.docker.com/r/airbyte/source-amazon-seller-partner
66
- sourceDefinitionId: d0243522-dccf-4978-8ba0-37ed47a0bdbf
77
name: Asana
@@ -23,7 +23,7 @@
2323
- sourceDefinitionId: 253487c0-2246-43ba-a21f-5116b20a2c50
2424
name: Google Ads
2525
dockerRepository: airbyte/source-google-ads
26-
dockerImageTag: 0.1.0
26+
dockerImageTag: 0.1.1
2727
documentationUrl: https://hub.docker.com/r/airbyte/source-google-ads
2828
- sourceDefinitionId: fdc8b827-3257-4b33-83cc-106d234c34d4
2929
name: Google Adwords (Deprecated)

airbyte-integrations/connectors/source-amazon-seller-partner/Dockerfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,5 +12,5 @@ RUN pip install .
1212
ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
1313
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]
1414

15-
LABEL io.airbyte.version=0.1.2
15+
LABEL io.airbyte.version=0.1.3
1616
LABEL io.airbyte.name=airbyte/source-amazon-seller-partner

airbyte-integrations/connectors/source-amazon-seller-partner/source_amazon_seller_partner/client.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ def __init__(
6363
self._amazon_client = AmazonClient(credentials=self.credentials, marketplace=marketplace)
6464

6565
def check_connection(self):
66-
updated_after = pendulum.now().subtract(days=self.CONVERSION_WINDOW_DAYS)
66+
updated_after = pendulum.now().subtract(days=self.CONVERSION_WINDOW_DAYS).to_date_string()
6767
return self._amazon_client.fetch_orders(updated_after, 10, None)
6868

6969
def get_streams(self):
@@ -103,7 +103,7 @@ def read_stream(
103103
yield self._record(stream=stream_name, data=order, seller_id=self.seller_id)
104104

105105
if cursor_value:
106-
state[stream_name][cursor_field] = pendulum.parse(cursor_value).add(days=1)
106+
state[stream_name][cursor_field] = pendulum.parse(cursor_value).add(days=1).to_date_string()
107107
yield self._state(state)
108108

109109
# Sleep for 2 seconds

airbyte-integrations/connectors/source-google-ads/Dockerfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,5 +11,5 @@ RUN pip install .
1111

1212
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]
1313

14-
LABEL io.airbyte.version=0.1.0
14+
LABEL io.airbyte.version=0.1.1
1515
LABEL io.airbyte.name=airbyte/source-google-ads

airbyte-integrations/connectors/source-google-ads/source_google_ads/spec.json

+1-4
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,7 @@
55
"title": "Google Ads Spec",
66
"type": "object",
77
"required": [
8-
"developer_token",
9-
"client_id",
10-
"client_secret",
11-
"refresh_token",
8+
"credentials",
129
"start_date",
1310
"customer_id"
1411
],

docs/integrations/sources/amazon-seller-partner.md

+1
Original file line numberDiff line numberDiff line change
@@ -58,3 +58,4 @@ Information about how to get credentials you may find [here](https://github.com/
5858
| Version | Date | Pull Request | Subject |
5959
| :------ | :-------- | :----- | :------ |
6060
| `0.1.2` | 2021-06-15 | [#4108](https://github.com/airbytehq/airbyte/pull/4108) | `Fixed: Sync fails with timeout when create report is CANCELLED` |
61+
| `0.1.3` | 2021-06-23 | [#4288](https://github.com/airbytehq/airbyte/pull/4288) | `Fixed: Create connection is failing` |

docs/integrations/sources/google-ads.md

+5
Original file line numberDiff line numberDiff line change
@@ -72,3 +72,8 @@ If for any reason the request gets denied, let us know and we will be able to un
7272

7373
The Google Ads Query Language can query the Google Ads API. Check out [Google Ads Query Language](https://developers.google.com/google-ads/api/docs/query/overview)
7474

75+
## CHANGELOG
76+
77+
| Version | Date | Pull Request | Subject |
78+
| :------ | :-------- | :----- | :------ |
79+
| `0.1.3` | 2021-06-23 | [#4288](https://github.com/airbytehq/airbyte/pull/4288) | `Fixed: Create source is failing` |

0 commit comments

Comments
 (0)