-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Connector logos #19346
Improve Connector logos #19346
Conversation
I cannot sign the agreement, because of “You must not submit any work that is not Your original creation.” :) |
@omid Without signing the CLA we unfortunately can't continue with this PR. The CLA applies in general to every PR you're doing against this repository, and notes that in general you commit your own work. Your own work in this case was adding the logos. Most countries (e.g. the US) have legal basis often called "fair/nominative use", that allows you do use logos to reference to the product or that company directly. In general: The logos we add for connectors should ideally be squared without padding, because that's how they'll be used across the UI. If you want to sign the CLA and continue on this PR, would you mind actually just using the "logo" portion of the corresponding icons i.e. the red "at-like" thing for mailgun, the green "s-like" part for seachmetrics, and the checkmark for Tempo (also I ❤️ how that logo got mixed up with Tempos :D), without any padding around them. cc @Upmitt |
@timroes OK, sure. Here you are. I also squared some more logos which were easy and obvious. |
cc @Upmitt (and also for back reference: #14496 (comment)) we have at the moment two PRs open that touch the icons. Since this one here has the smaller footprint, I'd suggest to finalize this one merge it, and then continue with the other. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed LGTM. Checked all logos in the UI, looks all good and as expected.
@omid Thank you so much for your contribution to Airbyte. We merged your contribution and you'll see it in Airbyte Cloud in a couple of days and the next available OSS release. |
* Better logos for some connectors * Square them + square a lot more icons! * revert two logos!
What
Not a big change, just better logos for some connectors