Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Connector logos #19346

Merged
merged 6 commits into from
Nov 14, 2022
Merged

Improve Connector logos #19346

merged 6 commits into from
Nov 14, 2022

Conversation

omid
Copy link
Contributor

@omid omid commented Nov 11, 2022

What

Not a big change, just better logos for some connectors

@CLAassistant
Copy link

CLAassistant commented Nov 11, 2022

CLA assistant check
All committers have signed the CLA.

@omid
Copy link
Contributor Author

omid commented Nov 11, 2022

I cannot sign the agreement, because of “You must not submit any work that is not Your original creation.” :)
Obviously, the logos are not mine :))

@timroes
Copy link
Contributor

timroes commented Nov 13, 2022

@omid Without signing the CLA we unfortunately can't continue with this PR. The CLA applies in general to every PR you're doing against this repository, and notes that in general you commit your own work. Your own work in this case was adding the logos. Most countries (e.g. the US) have legal basis often called "fair/nominative use", that allows you do use logos to reference to the product or that company directly.

In general: The logos we add for connectors should ideally be squared without padding, because that's how they'll be used across the UI. If you want to sign the CLA and continue on this PR, would you mind actually just using the "logo" portion of the corresponding icons i.e. the red "at-like" thing for mailgun, the green "s-like" part for seachmetrics, and the checkmark for Tempo (also I ❤️ how that logo got mixed up with Tempos :D), without any padding around them.

cc @Upmitt

@omid
Copy link
Contributor Author

omid commented Nov 13, 2022

@timroes OK, sure. Here you are. I also squared some more logos which were easy and obvious.
We also loled about the Tempos logo 😆

@timroes
Copy link
Contributor

timroes commented Nov 14, 2022

cc @Upmitt (and also for back reference: #14496 (comment)) we have at the moment two PRs open that touch the icons. Since this one here has the smaller footprint, I'd suggest to finalize this one merge it, and then continue with the other.

Copy link
Contributor

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed LGTM. Checked all logos in the UI, looks all good and as expected.

@timroes timroes changed the title Better logos for some connectors Improve Connector logos Nov 14, 2022
@timroes timroes merged commit 03b0d31 into airbytehq:master Nov 14, 2022
@timroes
Copy link
Contributor

timroes commented Nov 14, 2022

octavia-loves

@omid Thank you so much for your contribution to Airbyte. We merged your contribution and you'll see it in Airbyte Cloud in a couple of days and the next available OSS release.

akashkulk pushed a commit that referenced this pull request Dec 2, 2022
* Better logos for some connectors

* Square them + square a lot more icons!

* revert two logos!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants