🎉 Added new icons and updated old #14496
Conversation
|
Hi! I'm sorry to say that but I think all the icons need to be updated... The new icons seems to be pixel logo converted to vectors, so the quality is really not good.
Also, all those icons have different sizes and proportions, the result will not be homogeneous. I created a figma file with all the connectors logo, integrated in a square area, with right margins and proportions, this are the icons to use. Please let me know if some icons are missing, or if you need help to export this icons. (please DO NOT modify those icons in Figma as this are components used in all our product design files.) Here is the Figma file with the icons to use: https://www.figma.com/file/gMNRYVJav25pdsoxAyW7Qp/00_01_WEB-APP-LIBRARIES?node-id=2%3A675 |
|
@lazebnyi - I just sent you an invite, you should have access now |
lazebnyi
requested review from
Phlair,
Upmitt,
girarda and
sherifnada
and removed request for
a team
|
I think @Upmitt should approve here |
|
@Upmitt Will be back next week. |
|
This logos need to be updated (bad quality or wrong padding) - This logos were not in my Figma file, I'll let you know as soon as I update Figma (will try to do that tomorrow morning) Other logos seems ok :)
|
|
@andyjih here are the new .svg |
|
@Upmitt Also, the padding around the SVGs makes them look a little small to me in the UI with the current size of the icon: Is this desired? Or should we change increase/adjust size of the icon container at all to make these slightly larger? |
lmossman
force-pushed
the
lazebnyi/13491-update-logos-to-optimize-ux
branch
from
f8273c5 to
5e96030
Compare
|
AWESOME!! Thank you @lmossman !! I'll create the missing icons :) regarding the size, I use those square Icons in all my designs, for example in the dropdowns: https://www.figma.com/file/gMNRYVJav25pdsoxAyW7Qp/00_01_WEB-APP-LIBRARIES?node-id=1406%3A2576 - I think you can reduce the space between icon and name, and increase the Icon size (34px in Figma) Thank you again ! |
|
@Upmitt could you check PR again plz |
|
Hey @YowanR |
|
Adding to what Lake said here: A lot of the icons now have a margin around them in the SVG. This should not be done. @Upmitt You mentioend we can increase them in the UI, but this PR adds this marging inside the SVGs, so we can't really do that. In general the icon files should imho not have any unnecessary padding around the actual icon (except in one dimension to make it squared). If we have the padding in the icon files, we basically take away any possibility to change that quickly or adjust to it within the UI. COuld we please make sure that all icons in this PR are properly trimmed so the icon is touching the border? |
There was a problem hiding this comment.
Couple of other things despite the padding, that I noticed:
- airbyte-config/init/src/main/resources/icons/azureblobstorage.svg has a white background behind the logo that it didn't had beforehand
- airbyte-config/init/src/main/resources/icons/zohocrm.svg has a white background as well, that should be transparent
- airbyte-config/init/src/main/resources/icons/orbit.svg has a white background. Also it looks to me like a really badly traced bitmap? Is there any chance we can get a proper SVG logo here?
- airbyte-config/init/src/main/resources/icons/openweather.svg has a white background
- airbyte-config/init/src/main/resources/icons/linkedinads.svg has a white background
- airbyte-config/init/src/main/resources/icons/github.svg We're using here the logo meant for larger presentation (the one that has the dots in the tail). Since we usually show them rather small I'd suggest we stay with the one that is meant for smaller screens (without dots in the tail)
Questions:
- Is there a specific reason we're going for Stripe from the nicely squared logo (that would fit well in our UI) to the more stretched text one, that will look worse in a squared context?
|
A note. A community member opened #19346 which also corrects a lot of the squaring. I'd suggest we first merge the community PR, so we're not having that require too much more merge conflicts and then continue on this PR here, with the remaining icons. |
|
We just merged #19346. This PR should now be brought back with master and doesn't need to touch the icons, already fixed in that other PR. |
|
Hi @timroes |
|
@lazebnyi Yes I think we can close this PR. Nico is working on the full icon set, and we'd then open a new PR once we have the renewed icons. |
What
#13491 - Update logos to optimize UX
How
Added new icons and updated old