Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cdk and docs: remove "additionalProperties" #14881

Merged
merged 9 commits into from
Jul 22, 2022
Merged

cdk and docs: remove "additionalProperties" #14881

merged 9 commits into from
Jul 22, 2022

Conversation

alafanechere
Copy link
Contributor

@alafanechere alafanechere commented Jul 20, 2022 •
edited
Loading

What

#14878 added a test to make acceptance tests fail if additionalProperties: false. But most of our CDK docs show additionalProperties: false and the connectors-template generate specs with additionalProperties: false. This PR makes the required changes in connectors templates and docs.

How

Change additionalProperties: false to additionalProperties: true on *.md and *.hbs

@github-actions github-actions bot added area/documentation Improvements or additions to documentation CDK Connector Development Kit labels Jul 20, 2022
@alafanechere alafanechere marked this pull request as ready for review July 20, 2022 14:58
@alafanechere alafanechere requested a review from a team July 20, 2022 14:58
@alafanechere alafanechere linked an issue Jul 20, 2022 that may be closed by this pull request
CDK and doc: use "additionalProperties": true instead of false #14879
Closed
@alafanechere alafanechere requested a review from pedroslopez July 20, 2022 15:00
@sherifnada
Copy link
Contributor

make sure to follow the checklist for updating the connector generator templates, you'll need to update scaffolding projects

@alafanechere
Copy link
Contributor Author

make sure to follow the checklist for updating the connector generator templates, you'll need to update scaffolding projects

@sherifnada do you mean following this checklist?

@sherifnada
Copy link
Contributor

@alafanechere https://github.com/airbytehq/airbyte/blob/master/.github/pull_request_template.md the "Connector Generator" header

@alafanechere alafanechere requested review from a team as code owners July 21, 2022 18:05
@github-actions github-actions bot added area/platform issues related to the platform area/frontend Related to the Airbyte webapp labels Jul 21, 2022
@github-actions github-actions bot added the area/connectors Connector related issues label Jul 21, 2022
@alafanechere alafanechere changed the title cdk and docs: remove "additionalProperties": false cdk and docs: remove `"additionalProperties" Jul 21, 2022
@alafanechere alafanechere changed the title cdk and docs: remove `"additionalProperties" cdk and docs: remove "additionalProperties" Jul 21, 2022
@alafanechere alafanechere requested a review from pedroslopez July 21, 2022 18:15
pedroslopez
pedroslopez requested changes Jul 21, 2022
View reviewed changes
Copy link
Contributor

@pedroslopez pedroslopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! I think we shouldn't change the protocol model definitions here and let them reflect the real contents.

@alafanechere
Copy link
Contributor Author

@pedroslopez I reverted the changes on the Airbyte protocol docs + fixed the typo in the *.hbs file (and re-generated scaffolds). I don't think I need to bump / publish anything but let me know if I'm wrong.

@alafanechere alafanechere requested a review from pedroslopez July 22, 2022 08:45
pedroslopez
pedroslopez approved these changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@pedroslopez pedroslopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@alafanechere alafanechere merged commit 4df0a48 into master Jul 22, 2022
@alafanechere alafanechere deleted the augustin/cdk/remove-additional-properties-false branch July 22, 2022 13:34
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Jul 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedroslopez pedroslopez pedroslopez approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation area/frontend Related to the Airbyte webapp area/platform issues related to the platform CDK Connector Development Kit connectors/source/scaffold-java-jdbc connectors/source/scaffold-source-http connectors/source/scaffold-source-python team/extensibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CDK and doc: use "additionalProperties": true instead of false
4 participants
@alafanechere @sherifnada @pedroslopez @octavia-squidington-iii