Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDK and doc: use "additionalProperties": true instead of false #14879

Closed
alafanechere opened this issue Jul 20, 2022 · 0 comments · Fixed by #14881
Closed

CDK and doc: use "additionalProperties": true instead of false #14879

alafanechere opened this issue Jul 20, 2022 · 0 comments · Fixed by #14881
Assignees
Labels
area/connectors Connector related issues CDK Connector Development Kit needs-triage team/extensibility type/bug Something isn't working

Comments

@alafanechere
Copy link
Contributor

alafanechere commented Jul 20, 2022

A SAT addition (#14878) enforces connectors to use the value true for the additionalProperties field that can be declared in json schema of spec or stream.
Our tutorials and code generation template are not up to date to follow this new rule.

Acceptance criteria:

  • All occurrences of "additionalProperties": false are replaced to "additionalProperties": true in tutorial and template files. Grepping in *.md and *.hbs should be enough.
  • If the schema generator tool (tools/schema_generator) should not generates schema with "additionalProperties": false please make it generate "additionalProperties": true
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues CDK Connector Development Kit needs-triage team/extensibility type/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant