Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix back link on signup page #10732

Merged
merged 2 commits into from
Mar 1, 2022
Merged

Fix back link on signup page #10732

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f61f29
Fix back link on signup page
Feb 28, 2022
8e7c64c
Add and correct uiConfig links
Mar 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions airbyte-webapp/src/packages/cloud/views/auth/components/Header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,10 @@ const Links = styled.div`
align-items: center;
`;

const BackLink = styled.div`
const BackLink = styled.a`
font-style: normal;
font-weight: bold;
font-size: 14px;
line-height: 17px;
Comment on lines -22 to -23
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ This styles were unnecessaary, since this div does not contain anything besides the icon (to which those don't apply) and the TextBlock div below, which overwrote them. They did not affect rendering at all.

color: ${({ theme }) => theme.primaryColor};
cursor: pointer;

&:hover {
opacity: 0.8;
Expand All @@ -47,7 +44,7 @@ type HeaderProps = {
const Header: React.FC<HeaderProps> = ({ toLogin }) => {
return (
<Links>
<BackLink>
<BackLink href="https://airbyte.com">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we put it into config ui just as any other ui global variables?

<FontAwesomeIcon icon={faArrowLeft} />
<TextBlock>Back</TextBlock>
</BackLink>
Expand Down