Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix back link on signup page #10732

Merged
merged 2 commits into from
Mar 1, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 12 additions & 28 deletions airbyte-webapp/src/config/uiConfig.ts
Original file line number Diff line number Diff line change
@@ -1,43 +1,27 @@
const BASE_DOCS_LINK = "https://docs.airbyte.io";

type UiConfig = {
helpLink: string;
gitLink: string;
updateLink: string;
slackLink: string;
termsLink: string;
privacyLink: string;
docsLink: string;
configurationArchiveLink: string;
namespaceLink: string;
normalizationLink: string;
tutorialLink: string;
technicalSupport: string;
statusLink: string;
recipesLink: string;
demoLink: string;
syncModeLink: string;
};

const uiConfig: UiConfig = {
const uiConfig = {
technicalSupport: `${BASE_DOCS_LINK}/troubleshooting/on-deploying`,
termsLink: "https://airbyte.io/terms",
privacyLink: "https://airbyte.io/privacy-policy",
helpLink: "https://airbyte.io/community",
gitLink: "https://docs.airbyte.io/quickstart/deploy-airbyte",
termsLink: "https://airbyte.com/terms",
privacyLink: "https://airbyte.com/privacy-policy",
helpLink: "https://airbyte.com/community",
gitLink: "https://docs.airbyte.com/quickstart/deploy-airbyte",
updateLink: `${BASE_DOCS_LINK}/upgrading-airbyte`,
slackLink: "https://slack.airbyte.io",
slackLink: "https://slack.airbyte.com",
docsLink: BASE_DOCS_LINK,
configurationArchiveLink: `${BASE_DOCS_LINK}/tutorials/upgrading-airbyte`,
normalizationLink: `${BASE_DOCS_LINK}/understanding-airbyte/connections#airbyte-basic-normalization`,
namespaceLink: `${BASE_DOCS_LINK}/understanding-airbyte/namespaces`,
tutorialLink: "https://www.youtube.com/watch?v=Rcpt5SVsMpk&feature=emb_logo",
statusLink: "https://status.airbyte.io/",
recipesLink: "https://airbyte.io/recipes",
recipesLink: "https://airbyte.com/recipes",
syncModeLink:
"https://docs.airbyte.io/understanding-airbyte/connections/incremental-deduped-history",
"https://docs.airbyte.com/understanding-airbyte/connections/incremental-deduped-history",
demoLink: "https://demo.airbyte.io",
};
webpageLink: "https://airbyte.com",
} as const;

type UiConfig = Record<keyof typeof uiConfig, string>;

export type { UiConfig };
export { uiConfig };
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import { faArrowLeft } from "@fortawesome/free-solid-svg-icons";

import { Button } from "components";
import { CloudRoutes } from "../../../cloudRoutes";
import { useConfig } from "config";

const Links = styled.div`
width: 100%;
Expand All @@ -16,13 +17,10 @@ const Links = styled.div`
align-items: center;
`;

const BackLink = styled.div`
const BackLink = styled.a`
font-style: normal;
font-weight: bold;
font-size: 14px;
line-height: 17px;
Comment on lines -22 to -23
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ This styles were unnecessaary, since this div does not contain anything besides the icon (to which those don't apply) and the TextBlock div below, which overwrote them. They did not affect rendering at all.

color: ${({ theme }) => theme.primaryColor};
cursor: pointer;

&:hover {
opacity: 0.8;
Expand All @@ -45,9 +43,11 @@ type HeaderProps = {
};

const Header: React.FC<HeaderProps> = ({ toLogin }) => {
const { ui } = useConfig();

return (
<Links>
<BackLink>
<BackLink href={ui.webpageLink}>
<FontAwesomeIcon icon={faArrowLeft} />
<TextBlock>Back</TextBlock>
</BackLink>
Expand Down