Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source mysql: Datetime mapping #10305

Closed
wants to merge 4 commits into from
Closed

Source mysql: Datetime mapping #10305

wants to merge 4 commits into from

Conversation

harshithmullapudi
Copy link
Contributor

What

closes #9891

@github-actions github-actions bot added area/connectors Connector related issues area/platform issues related to the platform area/protocol labels Feb 13, 2022
@harshithmullapudi
Copy link
Contributor Author

harshithmullapudi commented Feb 13, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-mysql

🕑 connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/1837036596
❌ connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/1837036596
🐛 https://gradle.com/s/a573ererqzr2q

@harshithmullapudi harshithmullapudi temporarily deployed to more-secrets February 13, 2022 14:15 Inactive
@harshithmullapudi harshithmullapudi temporarily deployed to more-secrets February 13, 2022 14:15 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets February 13, 2022 14:17 Inactive
@harshithmullapudi harshithmullapudi temporarily deployed to more-secrets February 13, 2022 14:29 Inactive
@harshithmullapudi harshithmullapudi temporarily deployed to more-secrets February 13, 2022 14:29 Inactive
@harshithmullapudi harshithmullapudi requested review from tuliren and removed request for tuliren February 13, 2022 14:30
tuliren
tuliren reviewed Feb 13, 2022
View reviewed changes
Copy link
Contributor

@tuliren tuliren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as in #9891 (review). We are already working on a more generic solution for the date and time types. The most recent PR is #9913. Let's not merge this one.

@Morpheus1999 Morpheus1999 mentioned this pull request Feb 14, 2022
Closed
40 tasks
@CLAassistant
Copy link

CLAassistant commented May 5, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuliren tuliren tuliren left review comments

Assignees
No one assigned
Labels
area/connectors Connector related issues area/platform issues related to the platform area/protocol connectors/source/mysql
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@harshithmullapudi @CLAassistant @tuliren @bleonard @octavia-squidington-iii @Morpheus1999